Commit e619fad5 authored by catch's avatar catch
Browse files

Issue #3146567 by alexpott, pacproduct: Wrong key name in "Missing required... 

Issue #3146567 by alexpott, pacproduct: Wrong key name in "Missing required key (base_theme)" exception message

(cherry picked from commit 79835b02)
parent 756fe35b

core/lib/Drupal/Core/Extension/ThemeExtensionList.php

+1 −1
Original line number Diff line number Diff line
@@ -266,7 +266,7 @@ protected function createExtensionInfo(Extension $extension) { 
    $info = parent::createExtensionInfo($extension);



    if (!isset($info['base theme'])) {

      throw new InfoParserException('Missing required key (base_theme) in ' . $extension->getExtensionPathname() . '/' . $extension->getExtensionFilename());

      throw new InfoParserException(sprintf('Missing required key ("base theme") in %s/%s, see https://www.drupal.org/node/3066038', $extension->getExtensionPathname(), $extension->getExtensionFilename()));

    }



    // Remove the base theme when 'base theme: false' is set in a theme

core/tests/Drupal/KernelTests/Core/Theme/BaseThemeMissingTest.php

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ public function testMissingBaseThemeException() { 
      ->setInfoParser(new VfsInfoParser('vfs:/'));



    $this->expectException(InfoParserException::class);

    $this->expectExceptionMessage('Missing required key (base_theme) in themes/test_missing_base_theme/test_missing_base_theme.theme/test_missing_base_theme.theme');

    $this->expectExceptionMessage('Missing required key ("base theme") in themes/test_missing_base_theme/test_missing_base_theme.theme/test_missing_base_theme.theme, see https://www.drupal.org/node/3066038');

    $this->themeInstaller->install(['test_missing_base_theme']);

  }