Skip to content
Snippets Groups Projects
Commit e5881439 authored by catch's avatar catch
Browse files

Issue #3302800 by nod_, quietone, longwave: Core tests need to filter out...

Issue #3302800 by nod_, quietone, longwave: Core tests need to filter out deprecated themes when looping over all themes

(cherry picked from commit d1860b9d)
parent 4cc760e1
No related branches found
No related tags found
24 merge requests!8506Draft: Issue #3456536 by ibrahim tameme,!5646Issue #3350972 by nod_: [random test failure]...,!5600Issue #3350972 by nod_: [random test failure]...,!5343Issue #3305066 by quietone, Rename RedirectLeadingSlashesSubscriber,!4350Issue #3307718: Implement xxHash for non-cryptographic use-cases,!3603#ISSUE 3346218 Add a different message on edit comment,!3555Issue #2473873: Views entity operations lack cacheability support, resulting in incorrect dropbuttons,!3494Issue #3327018 by Spokje, longwave, xjm, mondrake: Update PHPStan to 1.9.3 and...,!3410Issue #3340128: UserLoginForm::submitForm has some dead code,!3389Issue #3325184 by Spokje, andypost, xjm, smustgrave: $this->configFactory is...,!3381Issue #3332363: Refactor Claro's menus-and-lists stylesheet,!3307Issue #3326193: CKEditor 5 can grow past the viewport when there is a lot of content,!3236Issue #3332419: Refactor Claro's messages stylesheet,!3231Draft: Issue #3049525 by longwave, fougere, larowlan, kim.pepper, AaronBauman, Wim...,!3212Issue #3294003: Refactor Claro's entity-meta stylesheet,!3194Issue #3330981: Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated...",!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3024Issue #3307509: Empty option for views bulk form,!2972Issue #1845004: Replace custom password hashing library with PHP 5.5 password_hash(),!2719Issue #3110137: Remove Classy from core.,!2688Issue #3261452: [PP-1] Remove tracker module from core,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2296Issue #3100732: Allow specifying `meta` data on JSON:API objects,!1626Issue #3256642: Make life better for database drivers that extend another database driver
......@@ -423,7 +423,7 @@ public function testInvalidTheme() {
public function testUninstallingThemes() {
// Install olivero.
\Drupal::service('theme_installer')->install(['olivero']);
// Set up claro as the admin theme.
// Set up Claro as the admin theme.
\Drupal::service('theme_installer')->install(['claro']);
$edit = [
'admin_theme' => 'claro',
......@@ -431,6 +431,7 @@ public function testUninstallingThemes() {
];
$this->drupalGet('admin/appearance');
$this->submitForm($edit, 'Save configuration');
// Set olivero as the default theme.
$this->cssSelect('a[title="Set Olivero as default theme"]')[0]->click();
// Check that claro cannot be uninstalled as it is the admin theme.
......
......@@ -6,6 +6,7 @@
use Drupal\Core\Extension\ExtensionDiscovery;
use Drupal\comment\CommentInterface;
use Drupal\comment\Plugin\Field\FieldType\CommentItemInterface;
use Drupal\Core\Extension\ExtensionLifecycle;
use Drupal\node\NodeInterface;
use Drupal\comment\Entity\Comment;
use Drupal\taxonomy\Entity\Term;
......@@ -87,6 +88,15 @@ protected function setUp(): void {
// Install all available non-testing themes.
$listing = new ExtensionDiscovery(\Drupal::root());
$this->themes = $listing->scan('theme', FALSE);
/** @var \Drupal\Core\Extension\ThemeHandlerInterface $theme_handler */
$theme_data = \Drupal::service('theme_handler')->rebuildThemeData();
foreach (array_keys($this->themes) as $theme) {
// Skip obsolete and deprecated themes.
$info = $theme_data[$theme]->info;
if ($info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::OBSOLETE || $info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::DEPRECATED) {
unset($this->themes[$theme]);
}
}
\Drupal::service('theme_installer')->install(array_keys($this->themes));
// Create a test user.
......
......@@ -60,10 +60,9 @@ class ResolvedLibraryDefinitionsFilesMatchTest extends KernelTestBase {
* @var string[]
*/
protected $allThemes = [
'bartik',
'claro',
'classy',
'olivero',
'seven',
'stable',
'stark',
];
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment