Commit e330762f authored by catch's avatar catch
Browse files

Issue #3309341 by lauriii, nod_: Remove toolbar/toolbar dependency on Modernizr 

(cherry picked from commit a3b4919b)
parent b4b0f9b9

core/modules/toolbar/tests/src/FunctionalJavascript/ToolbarIntegrationTest.php

+0 −2
Original line number Diff line number Diff line
@@ -37,8 +37,6 @@ public function testToolbarToggling() { 
    $this->drupalGet('<front>');

    $this->assertNotEmpty($this->assertSession()->waitForElement('css', 'body.toolbar-horizontal'));

    $this->assertNotEmpty($this->assertSession()->waitForElementVisible('css', '.toolbar-tray'));

    // Confirm touchevents detection is loaded with the toolbar.

    $this->assertNotNull($this->assertSession()->waitForElement('css', 'html.no-touchevents'));



    $page = $this->getSession()->getPage();

core/modules/toolbar/toolbar.libraries.yml

+0 −7
Original line number Diff line number Diff line
@@ -18,13 +18,6 @@ toolbar: 
      css/toolbar.theme.css: {}

      css/toolbar.icons.theme.css: {}

  dependencies:

    - core/modernizr

    # Toolbar does not use touchevents detection, nor does it use Modernizr.

    # Despite not using Modernizr, it loads it. Sites that expect modernizr to

    # be available may be getting it due to it being part of Toolbar. Because

    # of this, we must include drupal.touchevents-test so the expected

    # `touchevents/no-touchevents` classes are still added to the page.

    - core/drupal.touchevents-test

    - core/jquery

    - core/drupal

    - core/drupalSettings