Skip to content
Snippets Groups Projects
Verified Commit e11c30b5 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3259090 by Lendude, mr.york, Pandepoulus: Exposed filter equality check...

Issue #3259090 by Lendude, mr.york, Pandepoulus: Exposed filter equality check works differently in PHP 8.0

(cherry picked from commit 812ec978)
parent 7d74fbac
No related branches found
No related tags found
17 merge requests!8506Draft: Issue #3456536 by ibrahim tameme,!5646Issue #3350972 by nod_: [random test failure]...,!5600Issue #3350972 by nod_: [random test failure]...,!5343Issue #3305066 by quietone, Rename RedirectLeadingSlashesSubscriber,!3603#ISSUE 3346218 Add a different message on edit comment,!3555Issue #2473873: Views entity operations lack cacheability support, resulting in incorrect dropbuttons,!3494Issue #3327018 by Spokje, longwave, xjm, mondrake: Update PHPStan to 1.9.3 and...,!3410Issue #3340128: UserLoginForm::submitForm has some dead code,!3389Issue #3325184 by Spokje, andypost, xjm, smustgrave: $this->configFactory is...,!3381Issue #3332363: Refactor Claro's menus-and-lists stylesheet,!3307Issue #3326193: CKEditor 5 can grow past the viewport when there is a lot of content,!3236Issue #3332419: Refactor Claro's messages stylesheet,!3231Draft: Issue #3049525 by longwave, fougere, larowlan, kim.pepper, AaronBauman, Wim...,!3212Issue #3294003: Refactor Claro's entity-meta stylesheet,!3194Issue #3330981: Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated...",!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!2972Issue #1845004: Replace custom password hashing library with PHP 5.5 password_hash()
......@@ -1509,7 +1509,7 @@ public function acceptExposedInput($input) {
}
if ($this->operator != 'empty' && $this->operator != 'not empty') {
if ($value == 'All' || $value === []) {
if ($value == 'All' || $value === 0 || $value === []) {
return FALSE;
}
......
<?php
namespace Drupal\Tests\views\Unit\Plugin\filter;
use Drupal\Tests\UnitTestCase;
use Drupal\views\Plugin\views\filter\FilterPluginBase;
/**
* @coversDefaultClass \Drupal\views\Plugin\views\filter\FilterPluginBase
* @group views
*/
class FilterPluginBaseTest extends UnitTestCase {
/**
* @covers ::acceptExposedInput
*
* @dataProvider acceptExposedInputProvider
*/
public function testAcceptExposedInput(bool $expected_result, array $options, array $input) {
$definition = [
'title' => 'Accept exposed input Test',
'group' => 'Test',
];
$filter = new FilterPluginBaseStub([], 'stub', $definition);
$filter->options = $options;
$this->assertSame($expected_result, $filter->acceptExposedInput($input));
}
/**
* The data provider for testAcceptExposedInput.
*
* @return array
* The data set.
*/
public function acceptExposedInputProvider() {
return [
'not-exposed' => [TRUE, ['exposed' => FALSE], []],
'exposed-no-input' => [TRUE, ['exposed' => TRUE], []],
'exposed-zero-input' => [FALSE, [
'exposed' => TRUE,
'is_grouped' => FALSE,
'expose' => [
'use_operator' => TRUE,
'operator_id' => '=',
'identifier' => 'identifier',
],
], ['identifier' => 0],
],
'exposed-empty-array-input' => [FALSE, [
'exposed' => TRUE,
'is_grouped' => FALSE,
'expose' => [
'use_operator' => TRUE,
'operator_id' => '=',
'identifier' => 'identifier',
],
], ['identifier' => []],
],
];
}
}
class FilterPluginBaseStub extends FilterPluginBase {}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment