Issue #3439914 by pradhumanjain2311, sukr_s, vensires, smustgrave: Fix User...

Issue #3439914 by pradhumanjain2311, sukr_s, vensires, smustgrave: Fix User tests that rely on UID1's super user behavior

(cherry picked from commit eb219dc4)

core/modules/user/tests/src/Functional/UserRequirementsTest.php

@@ -13,14 +13,6 @@
  */
 class UserRequirementsTest extends BrowserTestBase {
 
-  /**
-   * {@inheritdoc}
-   *
-   * @todo Remove and fix test to not rely on super user.
-   * @see https://www.drupal.org/project/drupal/issues/3437620
-   */
-  protected bool $usesSuperUserAccessPolicy = TRUE;
-
   /**
    * {@inheritdoc}
    */
@@ -36,7 +28,10 @@ public function testAnonymousUser(): void {
       ->condition('uid', 0)
       ->execute();
 
-    $this->drupalLogin($this->rootUser);
+    $this->drupalLogin($this->drupalCreateUser([
+      'access administration pages',
+      'administer site configuration',
+    ]));
     $this->drupalGet('/admin/reports/status');
     $this->assertSession()->statusCodeEquals(200);
     $this->assertSession()->pageTextContains("The anonymous user does not exist.");

core/modules/user/tests/src/Kernel/WhoIsOnlineBlockTest.php

@@ -6,6 +6,7 @@
 
 use Drupal\block\Entity\Block;
 use Drupal\KernelTests\KernelTestBase;
+use Drupal\Tests\user\Traits\UserCreationTrait;
 use Drupal\user\Entity\User;
 
 /**
@@ -14,20 +15,13 @@
  * @group user
  */
 class WhoIsOnlineBlockTest extends KernelTestBase {
+  use UserCreationTrait;
 
   /**
    * {@inheritdoc}
    */
   protected static $modules = ['system', 'user', 'block', 'views'];
 
-  /**
-   * {@inheritdoc}
-   *
-   * @todo Remove and fix test to not rely on super user.
-   * @see https://www.drupal.org/project/drupal/issues/3437620
-   */
-  protected bool $usesSuperUserAccessPolicy = TRUE;
-
   /**
    * The block being tested.
    *
@@ -86,8 +80,8 @@ public function testWhoIsOnlineBlock() {
     $user1 = User::create([
       'name' => 'user1',
       'mail' => 'user1@example.com',
+      'roles' => [$this->createRole(['access user profiles'])],
     ]);
-    $user1->addRole('administrator');
     $user1->activate();
     $requestTime = \Drupal::time()->getRequestTime();
     $user1->setLastAccessTime($requestTime);