Commit df91ebe3 authored by Jess's avatar Jess
Browse files

Issue #3177557 by alexpott, andypost, dawehner:... 

Issue #3177557 by alexpott, andypost, dawehner: \Drupal\error_test\Controller\ErrorTestController::generateWarnings() notice is not a notice in PHP 8

(cherry picked from commit d678245f)
parent 3582dc24

core/modules/system/tests/modules/error_test/src/Controller/ErrorTestController.php

+2 −2
Original line number Diff line number Diff line
@@ -44,8 +44,8 @@ public function generateWarnings($collect_errors = FALSE) { 
    // Tell Drupal error reporter to send errors to Simpletest or not.

    define('SIMPLETEST_COLLECT_ERRORS', $collect_errors);

    // This will generate a notice.

    $bananas = [];

    $monkey_love = $bananas[1];

    $notice = new \stdClass();

    $notice == 1 ? 1 : 0;

    // This will generate a warning.

    $awesomely_big = 1 / 0;

    // This will generate a user error. Use & to check for double escaping.

core/modules/system/tests/src/Functional/System/ErrorHandlerTest.php

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ public function testErrorHandler() { 
    $config = $this->config('system.logging');

    $error_notice = [

      '%type' => 'Notice',

      '@message' => 'Undefined offset: 1',

      '@message' => 'Object of class stdClass could not be converted to int',

      '%function' => 'Drupal\error_test\Controller\ErrorTestController->generateWarnings()',

      '%file' => drupal_get_path('module', 'error_test') . '/error_test.module',

    ];