Commit d7eccc28 authored by catch's avatar catch
Browse files

Issue #3346748 by Lendude, borisson_: Entering a non-numeric value for a start... 

Issue #3346748 by Lendude, borisson_: Entering a non-numeric value for a start row value in 'Multiple field settings' for a views field leads to a fatal error

(cherry picked from commit d3d1d05d)
parent 4fd9eca1

core/modules/views/src/Plugin/views/field/EntityField.php

+1 −1
Original line number Diff line number Diff line
@@ -749,7 +749,7 @@ protected function prepareItemsByDelta(array $all_values) { 
        $offset = 0;

      }

      else {

        $delta_limit = $this->options['delta_limit'];

        $delta_limit = (int) $this->options['delta_limit'];

        $offset = intval($this->options['delta_offset']);



        // We should only get here in this case if there is an offset, and in

core/modules/views/tests/src/Unit/Plugin/field/FieldTest.php

+5 −0
Original line number Diff line number Diff line
@@ -649,6 +649,11 @@ public function providerTestPrepareItemsByDelta() { 
    $data[] = [['group_rows' => TRUE, 'delta_limit' => 1, 'delta_first_last' => TRUE], [3]];

    $data[] = [['group_rows' => TRUE, 'delta_offset' => 1, 'delta_first_last' => TRUE], [1, 9]];



    // Test with string values where we would expect integers to be provided.

    $data[] = [['group_rows' => TRUE, 'delta_limit' => 'All'], [3, 1, 4, 1, 5, 9]];

    $data[] = [['group_rows' => TRUE, 'delta_limit' => 'three'], [3, 1, 4, 1, 5, 9]];

    $data[] = [['group_rows' => TRUE, 'delta_limit' => 'three', 'delta_offset' => 'two'], [3, 1, 4, 1, 5, 9]];



    return $data;

  }