Skip to content
Snippets Groups Projects
Commit d7e7f3ac authored by catch's avatar catch
Browse files

Issue #2730807 by Lendude, versantus.nik, cilefen, xjm, SidneyGijzen,...

Issue #2730807 by Lendude, versantus.nik, cilefen, xjm, SidneyGijzen, smustgrave, almaudoh, alexpott, danflanagan8, jordan.jamous: WSOD on admin/modules if description is set but is NULL in module.info.yml

(cherry picked from commit b1d57de4)
parent 235b1393
Branches
Tags
20 merge requests!11628Update file MediaLibraryWidget.php,!7564Revert "Issue #3364773 by roshnichordiya, Chris Matthews, thakurnishant_06,...,!5752Issue #3275828 by joachim, quietone, bradjones1, Berdir: document the reason...,!5627Issue #3261805: Field not saved when change of 0 on string start,!5427Issue #3338518: send credentials in ajax if configured in CORS settings.,!5395Issue #3387916 by fjgarlin, Spokje: Each GitLab job exposes user email,!5217Issue #3386607 by alexpott: Improve spell checking in commit-code-check.sh,!5064Issue #3379522 by finnsky, Gauravvvv, kostyashupenko, smustgrave, Chi: Revert...,!5040SDC ComponentElement: Transform slots scalar values to #plain_text instead of throwing an exception,!4958Issue #3392147: Whitelist IP for a Ban module.,!4894Issue #3280279: Add API to allow sites to opt in to upload SVG images in CKEditor 5,!4857Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!4856Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!4788Issue #3272985: RSS Feed header reverts to text/html when cached,!4716Issue #3362929: Improve 400 responses for broken/invalid image style routes,!4553Draft: Issue #2980951: Permission to see own unpublished comments in comment thread,!3679Issue #115801: Allow password on registration without disabling e-mail verification,!3106Issue #3017548: "Filtered HTML" text format does not support manual teaser break (<!--break-->),!925Issue #2339235: Remove taxonomy hard dependency on node module,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links
......@@ -557,8 +557,13 @@ protected function createExtensionInfo(Extension $extension) {
// contributed extensions to use for ordering extension lists.
$info['mtime'] = $extension->getFileInfo()->getMTime();
// Merge extension type-specific defaults.
$info += $this->defaults;
// Merge extension type-specific defaults, making sure to replace NULL
// values.
foreach ($this->defaults as $key => $default_value) {
if (!isset($info[$key])) {
$info[$key] = $default_value;
}
}
return $info;
}
......
......@@ -121,6 +121,34 @@ public function testModulesListFormWithInvalidInfoFile() {
$this->assertSession()->pageTextNotContains('Modules could not be listed due to an error');
}
/**
* Tests the module form with a module with an empty description in info.yml.
*/
public function testModulesListFormWithEmptyDescriptionInfoFile() {
$path = \Drupal::getContainer()
->getParameter('site.path') . "/modules/missing_description";
mkdir($path, 0777, TRUE);
$file_path = "$path/missing_description.info.yml";
$yml = <<<BROKEN
name: Module with empty description
type: module
core_version_requirement: '*'
description:
BROKEN;
file_put_contents($file_path, $yml);
$this->drupalGet('admin/modules');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()
->pageTextContains("Module with empty description");
// Check that the module filter text box is available.
$this->assertSession()->elementExists('xpath', '//input[@name="text"]');
}
/**
* Confirm that module 'Required By' descriptions include dependent themes.
*/
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment