Verified Commit d75fdb1f authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #3326455 by el7cosmos, lauriii, joshuami, zenimagine, Wim Leers,... 

Issue #3326455 by el7cosmos, lauriii, joshuami, zenimagine, Wim Leers, smustgrave: [drupalMedia] When media is embedded in a view mode whose display is configured to link elsewhere, that link should not be clickable in CKEditor

(cherry picked from commit d80291c2)
parent b31b85bc

core/modules/ckeditor5/css/drupalmedia.css

+4 −0
Original line number Diff line number Diff line
@@ -13,6 +13,10 @@ 
  min-width: 50px;

}



.ck .drupal-media [data-drupal-media-preview] {

  pointer-events: none;

}



.ck-content .drupal-media img {

  display: block;

  min-width: 100%;

core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php

+21 −0
Original line number Diff line number Diff line
@@ -1673,4 +1673,25 @@ protected function getLastPreviewRequestTransferSize() { 
    return $this->getSession()->evaluateScript($javascript);

  }



  /**

   * Ensure media preview isn't clickable.

   */

  public function testMediaPointerEvent() {

    $entityViewDisplay = EntityViewDisplay::load('media.image.view_mode_1');

    $thumbnail = $entityViewDisplay->getComponent('thumbnail');

    $thumbnail['settings']['image_link'] = 'file';

    $entityViewDisplay->setComponent('thumbnail', $thumbnail);

    $entityViewDisplay->save();



    $assert_session = $this->assertSession();

    $page = $this->getSession()->getPage();

    $url = $this->host->toUrl('edit-form');

    $this->drupalGet($url);

    $this->waitForEditor();

    $assert_session->waitForLink('default alt');

    $page->find('css', '.ck .drupal-media')->click();

    // Assert that the media preview is not clickable by comparing the URL.

    $this->assertEquals($url->toString(), $this->getUrl());

  }



}