Skip to content
Snippets Groups Projects
Verified Commit d5f7540e authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3495733 by deepali sardana, idebr, knyshuk.vova: ManagedFile #accept... 

Issue #3495733 by deepali sardana, idebr, knyshuk.vova: ManagedFile #accept overwrites existing attributes

(cherry picked from commit 55d9324f)
parent f98eac78
Branches
Tags
21 merge requests!12227Issue #3181946 by jonmcl, mglaman,!12079Issue #3523476 by matthiasm11: Add empty check on operator,!12024Fix: DocBlock comment for return value of Drupal\Core\Database\Connection::transactionManager(),!11974Draft: Issue #3495165 by catch, joeyroth, berdir, texas-bronius: Better warning...,!11934Issue #3520997: DefaultLazyPluginCollection unnecessarily instantiates plugins when sorting collection,!11887Issue #3520065: The migrate Row class API is incomplete,!11636Draft: Issue #3515643 by macsim: fieldNameExists method is inconsistent,!11515Issue #3480419 by mondrake, smustgrave, catch: Method...,!11380Issue #3490698 by catch, spokje: Bump MINIMUM_STABILITY back to 'stable' when...,!11281Use Drupal Core Leadership terminology in MAINTAINERS.txt,!11239Issue #3507548: Allow workspace changes listing to show all items, without a pager,!11238Fix issue #3051797,!11213Issue #3506743 by tomislav.matokovic: Increasing the color contrast for the navigation block title against the background of the navigation sidebar to at least 4.5:1,!11147Draft: Try to avoid manually setting required cache contexts,!11108Issue #3490298 by nicxvan: Profiles can be missed in OOP hooks,!11093Drupal on MongoDB 11.1.x,!11017Issue #3502540: Add date filter for moderated content.,!11009Issue #3486972 migrate feed icon,!10999Cleaning up Taxonomy hooks and updating baseline.,!10977Issue #3501457: Fix path used in a A11y Test Admin,!10881Issue #3489329 by mfb, casey: symfony/http-foundation commit 32310ff breaks PathValidator
Pipeline #384476 passed
Stage: 🪄 Lint
Stage: 🗜️ Test
Pipeline: drupal

#384477

    Hide whitespace changes
    Inline Side-by-side
    core/modules/file/src/Element/ManagedFile.php
    + 1
    − 1
    View file @ d5f7540e
    ......@@ -326,7 +326,7 @@ public static function processManagedFile(&$element, FormStateInterface $form_st
    }
    if (!empty($element['#accept'])) {
    $element['upload']['#attributes'] = ['accept' => $element['#accept']];
    $element['upload']['#attributes']['accept'] = $element['#accept'];
    }
    // Indicate that $element['#title'] should be used as the HTML label for the
    ......
    core/modules/image/tests/src/Functional/ImageFieldWidgetTest.php
    + 2
    − 1
    View file @ d5f7540e
    ......@@ -27,6 +27,7 @@ public function testWidgetElement(): void {
    $min_resolution = 50;
    $max_resolution = 100;
    $field_settings = [
    'description' => 'test description',
    'max_resolution' => $max_resolution . 'x' . $max_resolution,
    'min_resolution' => $min_resolution . 'x' . $min_resolution,
    'alt_field' => 0,
    ......@@ -36,7 +37,7 @@ public function testWidgetElement(): void {
    // Verify that the image field widget is found on add/node page.
    $this->assertSession()->elementExists('xpath', '//div[contains(@class, "field--widget-image-image")]');
    // Verify that the image field widget limits accepted files.
    $this->assertSession()->elementExists('xpath', '//input[contains(@accept, "image/*")]');
    $this->assertSession()->elementExists('xpath', '//input[@aria-describedby][contains(@accept, "image/*")]');
    $this->assertSession()->pageTextNotContains('Image test on [site:name]');
    // Check for allowed image file extensions - default.
    ......
    0% or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment