Unverified Commit d4014a7d authored by Alex Pott's avatar Alex Pott
Browse files

task: #3587797 Move views data cache to cache_discovery 

By: catch
By: yujiman85
parent 5dd07510

core/modules/views/src/ViewsData.php

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ class ViewsData { 
  protected $langcode;



  public function __construct(

    #[Autowire(service: 'cache.default')]

    #[Autowire(service: 'cache.discovery')]

    protected CacheBackendInterface $cacheBackend,

    protected ModuleHandlerInterface $moduleHandler,

    protected LanguageManagerInterface $languageManager,

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php

+2 −2
Original line number Diff line number Diff line
@@ -131,11 +131,11 @@ protected function doTestNodePageAdministrator(): void { 
      'CacheGetCountByBin' => [

        'config' => 62,

        'bootstrap' => 16,

        'discovery' => 75,

        'discovery' => 88,

        'data' => 19,

        'entity' => 24,

        'dynamic_page_cache' => 1,

        'default' => 20,

        'default' => 7,

        'render' => 18,

        'menu' => 22,

      ],

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryNodePagePerformanceTest.php

+2 −2
Original line number Diff line number Diff line
@@ -221,12 +221,12 @@ protected function testNodePageWarmCache(): void { 
        'page' => 1,

        'config' => 34,

        'bootstrap' => 12,

        'discovery' => 67,

        'discovery' => 69,

        'data' => 7,

        'entity' => 21,

        'dynamic_page_cache' => 1,

        'render' => 17,

        'default' => 3,

        'default' => 1,

      ],

      'CacheSetCount' => 41,

      'CacheDeleteCount' => 0,

core/profiles/standard/tests/src/FunctionalJavascript/StandardPerformanceTest.php

+3 −14
Original line number Diff line number Diff line
@@ -135,12 +135,12 @@ protected function testAnonymous(): void { 
        'page' => 1,

        'config' => 20,

        'data' => 4,

        'discovery' => 39,

        'discovery' => 43,

        'bootstrap' => 10,

        'dynamic_page_cache' => 1,

        'render' => 11,

        'default' => 5,

        'entity' => 2,

        'default' => 1,

        'menu' => 3,

      ],

      'CacheSetCount' => 43,
@@ -177,10 +177,6 @@ protected function testAnonymous(): void { 
    ];

    $this->assertMetrics($expected, $performance_data);

    $expected_default_cache_cids = [

      'views_data:node_field_data:en',

      'views_data:en',

      'views_data:views:en',

      'views_data:node:en',

      'theme_registry:stark',

    ];

    $this->assertSame($expected_default_cache_cids, $performance_data->getCacheOperations()['get']['default']);
@@ -310,11 +306,10 @@ protected function testCacheInvalidation(): void { 
        'page' => 1,

        'config' => 11,

        'data' => 4,

        'discovery' => 21,

        'discovery' => 24,

        'bootstrap' => 8,

        'dynamic_page_cache' => 2,

        'render' => 12,

        'default' => 3,

        'entity' => 1,

        'menu' => 1,

      ],
@@ -362,12 +357,6 @@ protected function testCacheInvalidation(): void { 
      'StylesheetBytes' => 1300,

    ];

    $this->assertMetrics($expected, $performance_data);

    $expected_default_cache_cids = [

      'views_data:node_field_data:en',

      'views_data:views:en',

      'views_data:node:en',

    ];

    $this->assertSame($expected_default_cache_cids, $performance_data->getCacheOperations()['get']['default']);

  }



  /**