Commit d3fa5fa9 authored by Pierre Dureau's avatar Pierre Dureau
Browse files

Issue #3519917 by penyaskito, pdureau, larowlan: Disable additionalProperties... 

Issue #3519917 by penyaskito, pdureau, larowlan: Disable additionalProperties in slots in SDC json schema
parent 1cf42783

core/assets/schemas/v1/metadata-full.schema.json

+1 −0
Original line number Diff line number Diff line
@@ -4,6 +4,7 @@ 
  "$defs": {

    "slotDefinition": {

      "type": "object",

      "additionalProperties": false,

      "patternProperties": {

        "^[a-zA-Z0-9_-]+$": {

          "type": "object",

core/assets/schemas/v1/metadata.schema.json

+1 −0
Original line number Diff line number Diff line
@@ -4,6 +4,7 @@ 
  "$defs": {

    "slotDefinition": {

      "type": "object",

      "additionalProperties": false,

      "patternProperties": {

        "^[a-zA-Z0-9_-]+$": {

          "type": "object",

core/tests/Drupal/Tests/Core/Theme/Component/ComponentValidatorTest.php

+13 −0
Original line number Diff line number Diff line
@@ -124,6 +124,19 @@ public static function dataProviderValidateDefinitionInvalid(): \Generator { 
    ];

    yield 'invalid slot (type)' => [$cta_with_invalid_slot_type];



    $cta_with_invalid_slot_name = $valid_cta;

    $cta_with_invalid_slot_name['slots'] = [

      'valid_slot' => [

        'title' => 'Valid slot',

        'description' => 'Valid slot description',

      ],

      'invalid slot' => [

        'title' => 'Invalid slot',

        'description' => 'Slot name cannot have spaces',

      ],

    ];

    yield 'invalid slot (name with spaces)' => [$cta_with_invalid_slot_name];



    $cta_with_invalid_variant_title_type = $valid_cta;

    $cta_with_invalid_variant_title_type['variants'] = [

      'valid_variant' => [