Unverified Commit d39f9ce0 authored by alexpott's avatar alexpott

Issue #2934904 by kiamlaluno, ridhimaabrol24, Kristen Pol: Replace protected...

Issue #2934904 by kiamlaluno, ridhimaabrol24, Kristen Pol: Replace protected properties of TempStoreDatabaseTest with local variables

(cherry picked from commit 57a88194)
parent d91bfa62
......@@ -24,44 +24,26 @@ class TempStoreDatabaseTest extends KernelTestBase {
protected static $modules = ['system'];
/**
* A key/value store factory.
*
* @var \Drupal\Core\TempStore\SharedTempStoreFactory
*/
protected $storeFactory;
/**
* The name of the key/value collection to set and retrieve.
*
* @var string
*/
protected $collection;
/**
* An array of random stdClass objects.
*
* @var array
* {@inheritdoc}
*/
protected $objects = [];
protected function setUp(): void {
parent::setUp();
// Install system tables to test the key/value storage without installing a
// full Drupal environment.
$this->installSchema('system', ['key_value_expire']);
// Create several objects for testing.
for ($i = 0; $i <= 3; $i++) {
$this->objects[$i] = $this->randomObject();
}
}
/**
* Tests the SharedTempStore API.
*/
public function testSharedTempStore() {
// Create testing objects.
$objects = [];
for ($i = 0; $i <= 3; $i++) {
$objects[$i] = $this->randomObject();
}
// Create a key/value collection.
$database = Database::getConnection();
$factory = new SharedTempStoreFactory(new KeyValueExpirableFactory(\Drupal::getContainer()), new DatabaseLockBackend($database), $this->container->get('request_stack'));
......@@ -84,37 +66,37 @@ public function testSharedTempStore() {
for ($i = 0; $i <= 1; $i++) {
// setIfNotExists() should be TRUE the first time (when $i is 0) and
// FALSE the second time (when $i is 1).
$this->assertEqual(!$i, $stores[0]->setIfNotExists($key, $this->objects[$i]));
$this->assertEqual(!$i, $stores[0]->setIfNotExists($key, $objects[$i]));
$metadata = $stores[0]->getMetadata($key);
$this->assertEqual($users[0], $metadata->getOwnerId());
$this->assertEquals($this->objects[0], $stores[0]->get($key));
$this->assertEquals($objects[0], $stores[0]->get($key));
// Another user should get the same result.
$metadata = $stores[1]->getMetadata($key);
$this->assertEqual($users[0], $metadata->getOwnerId());
$this->assertEquals($this->objects[0], $stores[1]->get($key));
$this->assertEquals($objects[0], $stores[1]->get($key));
}
// Remove the item and try to set it again.
$stores[0]->delete($key);
$stores[0]->setIfNotExists($key, $this->objects[1]);
$stores[0]->setIfNotExists($key, $objects[1]);
// This time it should succeed.
$this->assertEquals($this->objects[1], $stores[0]->get($key));
$this->assertEquals($objects[1], $stores[0]->get($key));
// This user can update the object.
$stores[0]->set($key, $this->objects[2]);
$this->assertEquals($this->objects[2], $stores[0]->get($key));
$stores[0]->set($key, $objects[2]);
$this->assertEquals($objects[2], $stores[0]->get($key));
// The object is the same when another user loads it.
$this->assertEquals($this->objects[2], $stores[1]->get($key));
$this->assertEquals($objects[2], $stores[1]->get($key));
// This user should be allowed to get, update, delete.
$this->assertInstanceOf(\stdClass::class, $stores[0]->getIfOwner($key));
$this->assertTrue($stores[0]->setIfOwner($key, $this->objects[1]));
$this->assertTrue($stores[0]->setIfOwner($key, $objects[1]));
$this->assertTrue($stores[0]->deleteIfOwner($key));
// Another user can update the object and become the owner.
$stores[1]->set($key, $this->objects[3]);
$this->assertEquals($this->objects[3], $stores[0]->get($key));
$this->assertEquals($this->objects[3], $stores[1]->get($key));
$stores[1]->set($key, $objects[3]);
$this->assertEquals($objects[3], $stores[0]->get($key));
$this->assertEquals($objects[3], $stores[1]->get($key));
$metadata = $stores[1]->getMetadata($key);
$this->assertEqual($users[1], $metadata->getOwnerId());
......@@ -124,7 +106,7 @@ public function testSharedTempStore() {
// The first user should no longer be allowed to get, update, delete.
$this->assertNull($stores[0]->getIfOwner($key));
$this->assertFalse($stores[0]->setIfOwner($key, $this->objects[1]));
$this->assertFalse($stores[0]->setIfOwner($key, $objects[1]));
$this->assertFalse($stores[0]->deleteIfOwner($key));
// Now manually expire the item (this is not exposed by the API) and then
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment