Commit d2da6f29 authored by catch's avatar catch
Browse files

Issue #3228634 by Spokje, xjm, paulocs, tim.plunkett, Lendude: Move tests for... 

Issue #3228634 by Spokje, xjm, paulocs, tim.plunkett, Lendude: Move tests for integrations between QuickEdit and other modules into QuickEdit so that it can more easily be moved into contrib

(cherry picked from commit e4ce9936)
parent bfb29c24

core/modules/media/tests/src/Kernel/MediaEmbedFilterDisabledIntegrationsTest.php

+2 −19
Original line number Diff line number Diff line
@@ -15,7 +15,6 @@ class MediaEmbedFilterDisabledIntegrationsTest extends MediaEmbedFilterTestBase 
   */

  protected static $modules = [

    'contextual',

    'quickedit',

    // @see media_test_embed_entity_view_alter()

    'media_test_embed',

  ];
@@ -29,16 +28,14 @@ protected function setUp(): void { 
    $this->container->get('current_user')

      ->addRole($this->drupalCreateRole([

        'access contextual links',

        'access in-place editing',

      ]));

  }



  /**

   * @covers ::renderMedia

   * @covers ::disableContextualLinks

   * @dataProvider providerDisabledIntegrations

   */

  public function testDisabledIntegrations($integration_detection_selector) {

  public function testDisabledIntegrations() {

    $text = $this->createEmbedCode([

      'data-entity-type' => 'media',

      'data-entity-uuid' => static::EMBEDDED_ENTITY_UUID,
@@ -46,21 +43,7 @@ public function testDisabledIntegrations($integration_detection_selector) { 


    $this->applyFilter($text);

    $this->assertCount(1, $this->cssSelect('div[data-media-embed-test-view-mode]'));

    $this->assertCount(0, $this->cssSelect($integration_detection_selector));

  }



  /**

   * Data provider for testDisabledIntegrations().

   */

  public function providerDisabledIntegrations() {

    return [

      'contextual' => [

        'div[data-media-embed-test-view-mode].contextual-region',

      ],

      'quickedit' => [

        'div[data-media-embed-test-view-mode][data-quickedit-entity-id]',

      ],

    ];

    $this->assertCount(0, $this->cssSelect('div[data-media-embed-test-view-mode].contextual-region'));

  }



}

core/modules/editor/tests/src/Functional/QuickEditIntegrationLoadingTest.php→core/modules/quickedit/tests/src/Functional/EditorIntegrationLoadingTest.php

+4 −3
Original line number Diff line number Diff line 
<?php



namespace Drupal\Tests\editor\Functional;

namespace Drupal\Tests\quickedit\Functional;



use Drupal\Component\Serialization\Json;

use Drupal\Core\EventSubscriber\MainContentViewSubscriber;
@@ -10,9 +10,9 @@ 
/**

 * Tests Quick Edit module integration endpoints.

 *

 * @group editor

 * @group quickedit

 */

class QuickEditIntegrationLoadingTest extends BrowserTestBase {

class EditorIntegrationLoadingTest extends BrowserTestBase {



  /**

   * Modules to enable.
@@ -71,6 +71,7 @@ protected function setUp(): void { 
   * Tests loading of untransformed text when a user doesn't have access to it.

   */

  public function testUsersWithoutPermission() {

    $this->fail();

    // Create 3 users, each with insufficient permissions, i.e. without either

    // or both of the following permissions:

    // - the 'access in-place editing' permission

core/modules/layout_builder/tests/src/Functional/LayoutBuilderQuickEditTest.php→core/modules/quickedit/tests/src/Functional/LayoutBuilderQuickEditTest.php

+3 −2
Original line number Diff line number Diff line 
<?php



namespace Drupal\Tests\layout_builder\Functional;

namespace Drupal\Tests\quickedit\Functional;



use Drupal\Tests\BrowserTestBase;



/**

 * Tests Layout Builder integration with Quick Edit.

 *

 * @group layout_builder

 * @group quickedit

 */

class LayoutBuilderQuickEditTest extends BrowserTestBase {
@@ -45,6 +45,7 @@ protected function setUp(): void { 
   * Tests Quick Edit integration with a block from a different entity type.

   */

  public function testPlaceFieldBlockFromDifferentEntityType() {

    $this->fail();

    $page = $this->getSession()->getPage();



    $this->drupalLogin($this->drupalCreateUser([

core/modules/image/tests/src/Functional/QuickEditImageControllerTest.php→core/modules/quickedit/tests/src/Functional/QuickEditImageControllerTest.php

+3 −2
Original line number Diff line number Diff line 
<?php



namespace Drupal\Tests\image\Functional;

namespace Drupal\Tests\quickedit\Functional;



use Drupal\Component\Serialization\Json;

use Drupal\Tests\BrowserTestBase;
@@ -10,7 +10,7 @@ 
/**

 * Tests the endpoints used by the "image" in-place editor.

 *

 * @group image

 * @group quickedit

 */

class QuickEditImageControllerTest extends BrowserTestBase {
@@ -76,6 +76,7 @@ protected function setUp(): void { 
   * Tests that routes restrict access for un-privileged users.

   */

  public function testAccess() {

    $this->fail();

    // Create an anonymous user.

    $user = $this->createUser();

    $this->drupalLogin($user);

core/modules/inline_form_errors/tests/src/FunctionalJavascript/FormErrorHandlerQuickEditTest.php→core/modules/quickedit/tests/src/FunctionalJavascript/InlineFormErrorsIntegrationTest.php

+4 −3
Original line number Diff line number Diff line 
<?php



namespace Drupal\Tests\inline_form_errors\FunctionalJavascript;

namespace Drupal\Tests\quickedit\FunctionalJavascript;



use Drupal\FunctionalJavascriptTests\WebDriverTestBase;

use Drupal\node\Entity\NodeType;
@@ -8,9 +8,9 @@ 
/**

 * Tests Inline Form Errors compatibility with Quick Edit.

 *

 * @group inline_form_errors

 * @group quickedit

 */

class FormErrorHandlerQuickEditTest extends WebDriverTestBase {

class InlineFormErrorsIntegrationTest extends WebDriverTestBase {



  /**

   * Modules to enable.
@@ -60,6 +60,7 @@ protected function setUp(): void { 
   * Tests that the inline form errors are not visible for Quick Edit forms.

   */

  public function testDisabledInlineFormErrors() {

    $this->fail();

    $session = $this->getSession();

    $web_assert = $this->assertSession();