Unverified Commit d2647ca5 authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3213022 by andypost, jhodgdon: When generating link to non-existent... 

Issue #3213022 by andypost, jhodgdon: When generating link to non-existent help topic, put topic ID in fallback text
parent 573e752f

core/modules/help_topics/src/HelpTwigExtension.php

+3 −1
Original line number Diff line number Diff line
@@ -153,7 +153,9 @@ public function getTopicLink(string $topic_id): array { 
    }

    else {

      $build = [

        '#markup' => $this->t('Missing help topic'),

        '#markup' => $this->t('Missing help topic %topic', [

          '%topic' => $topic_id,

        ]),

      ];

    }

core/modules/help_topics/tests/src/Functional/HelpTopicTest.php

+1 −1
Original line number Diff line number Diff line
@@ -222,7 +222,7 @@ public function testHelpLinks() { 
      'invalid params' => FALSE,

      'valid link' => TRUE,

      'Additional topic' => TRUE,

      'Missing help topic' => FALSE,

      'Missing help topic not_a_topic' => FALSE,

    ];

    foreach ($links as $text => $should_be_link) {

      if ($should_be_link) {