Commit d0f0aba8 authored by Gábor Hojtsy's avatar Gábor Hojtsy

Issue #3037668 by starshaped, Gábor Hojtsy, phenaproxima, seanB, lauriii:...

Issue #3037668 by starshaped, Gábor Hojtsy, phenaproxima, seanB, lauriii: Improve visual coherence of the media library
parent 298fddc6
......@@ -45,7 +45,7 @@ display:
exposed_form:
type: basic
options:
submit_button: 'Apply Filters'
submit_button: 'Apply filters'
reset_button: false
reset_button_label: Reset
exposed_sorts_label: 'Sort by'
......
......@@ -52,10 +52,15 @@
position: absolute;
z-index: 1;
top: 5px;
right: 0;
right: 5px; /* LTR */
display: block;
}
[dir="rtl"] .media-library-item .js-click-to-select-checkbox {
right: 0;
left: 5px;
}
.media-library-item__status {
position: absolute;
top: 10px;
......
......@@ -210,7 +210,7 @@
.media-library-wrapper .view-header {
align-self: flex-end;
order: 2;
margin: 8px 0;
margin: 1em 0;
text-align: right; /* LTR */
}
[dir="rtl"] .media-library-wrapper .view-header {
......@@ -246,6 +246,7 @@
margin: 0;
padding-left: 22px; /* LTR */
color: #333;
font-size: 15px;
line-height: 16px;
}
[dir="rtl"] .media-library-wrapper .views-display-link {
......@@ -253,6 +254,10 @@
padding-left: 0;
}
.media-library-wrapper .views-display-link.is-active {
font-weight: bold;
}
.media-library-wrapper .views-display-link-widget {
margin-right: 15px;
background: url(../../../misc/icons/333333/grid.svg) left 0 no-repeat; /* LTR */
......
......@@ -99,19 +99,19 @@ public function testAdministrationPage() {
// Test that users can filter by type.
$page->selectFieldOption('Media type', 'Type One');
$page->pressButton('Apply Filters');
$page->pressButton('Apply filters');
$assert_session->assertWaitOnAjaxRequest();
$assert_session->pageTextContains('Dog');
$assert_session->pageTextNotContains('Turtle');
$page->selectFieldOption('Media type', 'Type Two');
$page->pressButton('Apply Filters');
$page->pressButton('Apply filters');
$assert_session->assertWaitOnAjaxRequest();
$assert_session->pageTextNotContains('Dog');
$assert_session->pageTextContains('Turtle');
// Test that selecting elements as a part of bulk operations works.
$page->selectFieldOption('Media type', '- Any -');
$page->pressButton('Apply Filters');
$page->pressButton('Apply filters');
$assert_session->assertWaitOnAjaxRequest();
// This tests that anchor tags clicked inside the preview are suppressed.
$this->getSession()->executeScript('jQuery(".js-click-to-select-trigger a")[4].click()');
......@@ -453,12 +453,12 @@ public function testWidget() {
$assert_session->assertWaitOnAjaxRequest();
$session = $this->getSession();
$session->getPage()->fillField('Name', 'Dog');
$session->getPage()->pressButton('Apply Filters');
$session->getPage()->pressButton('Apply filters');
$assert_session->assertWaitOnAjaxRequest();
$assert_session->pageTextContains('Dog');
$assert_session->pageTextNotContains('Bear');
$session->getPage()->fillField('Name', '');
$session->getPage()->pressButton('Apply Filters');
$session->getPage()->pressButton('Apply filters');
$assert_session->assertWaitOnAjaxRequest();
$assert_session->pageTextContains('Dog');
$assert_session->pageTextContains('Bear');
......@@ -489,7 +489,7 @@ public function testWidget() {
$assert_session->pageTextNotContains('Turtle');
// Assert the exposed filters can be applied.
$page->fillField('Name', 'Dog');
$page->pressButton('Apply Filters');
$page->pressButton('Apply filters');
$assert_session->assertWaitOnAjaxRequest();
$assert_session->pageTextContains('Dog');
$assert_session->pageTextNotContains('Bear');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment