Commit cf4a6098 authored by catch's avatar catch
Browse files

Issue #2409413 by cafuego, longwave, lokapujya, alexpott, alvar0hurtad0,... 

Issue #2409413 by cafuego, longwave, lokapujya, alexpott, alvar0hurtad0, SivaprasadC, snehi, vipul.patil7888, ayushmishra206, dawehner, xjm, mradcliffe: Remove fields that do nothing from the  "RSS publishing" settings form
parent f32886bf

core/modules/aggregator/tests/src/Functional/AggregatorTestBase.php

+2 −3
Original line number Diff line number Diff line
@@ -161,14 +161,13 @@ public function getFeedEditObject($feed_url = NULL, array $values = []) { 
  public function getDefaultFeedItemCount() {

    // Our tests are based off of rss.xml, so let's find out how many elements

    // should be related.

    $feed_count = \Drupal::entityQuery('node')

    return \Drupal::entityQuery('node')

      ->condition('promote', NodeInterface::PROMOTED)

      ->condition('status', NodeInterface::PUBLISHED)

      ->accessCheck(FALSE)

      ->range(0, $this->config('system.rss')->get('items.limit'))

      ->range(0, 10)

      ->count()

      ->execute();

    return min($feed_count, 10);

  }



  /**

core/modules/config_translation/tests/src/Functional/ConfigTranslationListUiTest.php

+0 −2
Original line number Diff line number Diff line
@@ -502,8 +502,6 @@ public function testTranslateOperationInListUi() { 
    $this->doSettingsPageTest('admin/config/system/site-information');

    // Test the account settings page.

    $this->doSettingsPageTest('admin/config/people/accounts');

    // Test the RSS settings page.

    $this->doSettingsPageTest('admin/config/services/rss-publishing');

  }



}

core/modules/config_translation/tests/src/Functional/ConfigTranslationUiTest.php

+0 −5
Original line number Diff line number Diff line
@@ -888,11 +888,6 @@ public function testAlterInfo() { 
    $this->container->get('state')->set('config_translation_test_config_translation_info_alter', TRUE);

    $this->container->get('plugin.manager.config_translation.mapper')->clearCachedDefinitions();



    // Check out if the translation page has the altered in settings.

    $this->drupalGet('admin/config/system/site-information/translate/fr/add');

    $this->assertText('Feed channel');

    $this->assertText('Feed description');



    // Check if the translation page does not have the altered out settings.

    $this->drupalGet('admin/config/people/accounts/translate/fr/add');

    $this->assertText('Name');

core/modules/config_translation/tests/src/Unit/ConfigNamesMapperTest.php

+0 −1
Original line number Diff line number Diff line
@@ -469,7 +469,6 @@ public function testGetConfigData() { 
      ],

      'system.rss' => [

        'items' => [

          'limit' => 10,

          'view_mode' => 'rss',

        ],

      ],

core/modules/system/config/install/system.rss.yml

+0 −4
Original line number Diff line number Diff line 
channel:

  description: ''

items:

  limit: 10

  view_mode: rss
 
langcode: en