Commit c82136d8 authored by catch's avatar catch
Browse files

Issue #3307471 by nod_, Spokje, bnjmnm: Deprecate popperjs

parent 099d151f

core/core.libraries.yml

+5 −5
Original line number Diff line number Diff line
@@ -1070,11 +1070,9 @@ jquery.ui.mouse: 
  deprecated: *jquery_ui_unused_deprecated



drupal.jquery.position:

  # For most positioning needs, the core/popperjs library should be used. This

  # is a modified version of jQuery UI position for that does not require any

  # jQuery UI assets, only jQuery. It is provided by core for use with

  # pre-existing libraries that expect the jQuery UI position API. Popperjs is

  # recommended for any new uses.

  # This is a modified version of jQuery UI position for that does not require

  # any jQuery UI assets, only jQuery. It is provided by core for use with

  # pre-existing libraries that expect the jQuery UI position API.

  version: VERSION

  js:

    misc/position.js: {}
@@ -1170,6 +1168,8 @@ popperjs: 
    - core/drupal.array.find

    - core/es6-promise

    - core/drupal.object.assign

  deprecated: The "%library_id%" asset library is deprecated in Drupal 9.5.0 and will be removed in Drupal 10.0.0. There is no replacement. See https://www.drupal.org/node/3307518





sortable:

  remote: https://github.com/SortableJS/Sortable

core/misc/position.es6.js

+2 −3
Original line number Diff line number Diff line
@@ -7,9 +7,8 @@ 
 * provided by jQuery UI position, but refactored to meet Drupal coding

 * standards, and restructured so it extends jQuery core instead of jQuery UI.

 *

 * For most positioning needs, the core/popperjs library should be used instead

 * of the functionality provided here. This is provided to support pre-existing

 * code that expects the jQuery position API.

 * This is provided to support pre-existing code that expects the jQuery

 * position API.

 *

 * @see https://github.com/jquery/jquery-ui/blob/1.12.1/LICENSE.txt

 * @see https://raw.githubusercontent.com/jquery/jquery-ui/1.12.1/ui/position.js

core/modules/system/tests/modules/common_test/common_test.libraries.yml

+2 −2
Original line number Diff line number Diff line 
popperjs:

loadjs:

  version: 0.1

  js:

    assets/vendor/popperjs/popper.min.js: { }

    assets/vendor/loadjs/loadjs.min.js: { }



# Library to test CSS and JS file assets.

files:

core/modules/system/tests/modules/common_test/common_test.module

+5 −5
Original line number Diff line number Diff line
@@ -170,11 +170,11 @@ function common_test_library_info_build() { 
 * Implements hook_library_info_alter().

 */

function common_test_library_info_alter(&$libraries, $module) {

  if ($module === 'core' && isset($libraries['popperjs'])) {

    // Change the version of Popper to 0.0.

    $libraries['popperjs']['version'] = '0.0';

    // Make Popper depend on jQuery Form to test library dependencies.

    $libraries['popperjs']['dependencies'][] = 'core/internal.jquery.form';

  if ($module === 'core' && isset($libraries['loadjs'])) {

    // Change the version of loadjs to 0.0.

    $libraries['loadjs']['version'] = '0.0';

    // Make loadjs depend on jQuery Form to test library dependencies.

    $libraries['loadjs']['dependencies'][] = 'core/internal.jquery.form';

  }



  // Alter the dynamically registered library definition.

core/modules/system/tests/themes/test_basetheme/test_basetheme.info.yml

+2 −2
Original line number Diff line number Diff line
@@ -11,9 +11,9 @@ libraries-override: 
  core/drupal.dialog:

    js:

      misc/dialog/dialog.js: false

  core/popperjs:

  core/loadjs:

    js:

      assets/vendor/popperjs/popper.min.js: js/popper.min.js

      assets/vendor/loadjs/loadjs.min.js: js/loadjs.min.js

  theme_test/theme_stylesheets_override_and_remove_test:

    css:

      base: