Unverified Commit bee62f64 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3127250 by anmolgoyal74, joseph.olstad, ankithashetty, fago, catch,... 

Issue #3127250 by anmolgoyal74, joseph.olstad, ankithashetty, fago, catch, alexpott: Node previews are cached by dynamic page cache

(cherry picked from commit ab9919c3)
parent 9116b234

core/modules/node/node.services.yml

+1 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ services: 
    public: false

    tags:

      - { name: page_cache_response_policy }

      - { name: dynamic_page_cache_response_policy }

  cache_context.user.node_grants:

    class: Drupal\node\Cache\NodeAccessGrantsCacheContext

    arguments: ['@current_user']

core/modules/node/tests/src/Functional/PagePreviewTest.php

+24 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ 
use Drupal\taxonomy\Entity\Vocabulary;

use Drupal\Tests\field\Traits\EntityReferenceTestTrait;

use Drupal\Tests\TestFileCreationTrait;

use Drupal\user\RoleInterface;



/**

 * Tests the node entity preview functionality.
@@ -500,4 +501,27 @@ public function testSimultaneousPreview() { 
    $this->assertText($edit2[$title_key]);

  }



  /**

   * Tests node preview with dynamic_page_cache and anonymous users.

   */

  public function testPagePreviewCache() {

    \Drupal::service('module_installer')->uninstall(['node_test']);

    $this->drupalLogout();

    $title_key = 'title[0][value]';

    user_role_grant_permissions(RoleInterface::ANONYMOUS_ID, ['create page content', 'access content']);

    $edit = [

      $title_key => $this->randomMachineName(8),

    ];

    $this->drupalGet('/node/add/page');

    $this->submitForm($edit, 'Preview');

    $this->assertSession()->pageTextContains($edit[$title_key]);

    $this->clickLink(t('Back to content editing'));



    $edit = [

      $title_key => $this->randomMachineName(8),

    ];

    $this->submitForm($edit, 'Preview');

    $this->assertSession()->pageTextContains($edit[$title_key]);

  }



}