Unverified Commit be8eb5ba authored by Alex Pott's avatar Alex Pott
Browse files

task: #3615571 Optimize update module's UpdateTestBase 

By: catch
By: quietone
By: dcam
By: mstrelan
parent 6ed53eb7

core/modules/update/src/UpdateManager.php

+1 −0
Changes for core/modules/update/src/UpdateManager.php: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -81,6 +81,7 @@ public function refreshUpdateData() { 
    // modules that implement hook_extension_info_alter() such as cvs_deploy.

    $this->keyValueStore->delete('update_project_projects');

    $this->keyValueStore->delete('update_project_data');

    $this->projects = [];



    $projects = $this->getProjects();

core/modules/update/src/UpdateProcessor.php

+1 −0
Changes for core/modules/update/src/UpdateProcessor.php: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -190,6 +190,7 @@ public function processFetchTask($project) { 
    // Now that we processed the fetch task for this project, clear out the

    // record for this task so we're willing to fetch again.

    $this->fetchTaskStore->delete($project_name);

    unset($this->fetchTasks[$project_name]);



    return $success;

  }

core/modules/update/tests/src/Functional/UpdateContribTest.php

+2 −2
Changes for core/modules/update/tests/src/Functional/UpdateContribTest.php: 2 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ public function testUpdateBaseThemeSecurityUpdate(): void { 
      'update_test_subtheme' => '1_0',

      'update_test_base_theme' => '1_1-sec',

    ];

    $this->refreshUpdateStatus($xml_mapping);

    $this->refreshUpdateStatus($xml_mapping, 'update-test', TRUE);

    $this->assertSession()->pageTextContains('Security update required!');

    $this->updateProject = 'update_test_base_theme';

    $this->assertVersionUpdateLinks('Security update', '8.x-1.1');
@@ -460,7 +460,7 @@ public function testUpdateBrokenFetchURL(): void { 
      'bbb_update_test' => 'does-not-exist',

      'ccc_update_test' => '1_0',

    ];

    $this->refreshUpdateStatus($xml_mapping);

    $this->refreshUpdateStatus($xml_mapping, 'update-test', TRUE);



    $this->assertSession()->pageTextContains('Up to date');

    // We're expecting the report to say most projects are up to date, so we

core/modules/update/tests/src/Functional/UpdateMiscTest.php

+1 −1
Changes for core/modules/update/tests/src/Functional/UpdateMiscTest.php: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ public function testServiceUnavailable(): void { 
      'administer site configuration',

    ]);

    $this->drupalLogin($admin_user);

    $this->refreshUpdateStatus([], '503-error');

    $this->refreshUpdateStatus([], '503-error', TRUE);

    // Ensure that no "Warning: SimpleXMLElement..." parse errors are found.

    $this->assertSession()->pageTextNotContains('SimpleXMLElement');

    $this->assertSession()->pageTextContainsOnce('Failed to get available update data for one project.');

core/modules/update/tests/src/Functional/UpdateSemverCoreTest.php

+1 −1
Changes for core/modules/update/tests/src/Functional/UpdateSemverCoreTest.php: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ public function testDatestampMismatch(): void { 
   * Tests the Update Status module when the update server returns 503 errors.

   */

  public function testServiceUnavailable(): void {

    $this->refreshUpdateStatus([], '503-error');

    $this->refreshUpdateStatus([], '503-error', TRUE);

    // Ensure that no "Warning: SimpleXMLElement..." parse errors are found.

    $this->assertSession()->pageTextNotContains('SimpleXMLElement');

    $this->assertSession()->pageTextContainsOnce('Failed to get available update data for one project.');