Skip to content
Snippets Groups Projects
Commit be839ae7 authored by Jess's avatar Jess
Browse files

Issue #3268368 by lauriii, xjm, Wim Leers: Robustify and restore...

Issue #3268368 by lauriii, xjm, Wim Leers: Robustify and restore \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest::testButton
parent 09597b73
No related branches found
No related tags found
38 merge requests!12227Issue #3181946 by jonmcl, mglaman,!7471uncessary 5 files are moved from media-library folder to misc folder,!7452Issue #1797438. HTML5 validation is preventing form submit and not fully...,!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!3630Issue #2815301 by Chi, DanielVeza, kostyashupenko, smustgrave: Allow to create...,!3291Issue #3336463: Rewrite rules for gzipped CSS and JavaScript aggregates never match,!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3102Issue #3164428 by DonAtt, longwave, sahil.goyal, Anchal_gupta, alexpott: Use...,!2853#3274419 Makes BaseFieldOverride inherit the internal property from the base field.,!2719Issue #3110137: Remove Classy from core.,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2074Issue #2707689: NodeForm::actions() checks for delete access on new entities,!2062Issue #3246454: Add weekly granularity to views date sort,!1974Issue #3036862 demonstration,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1254Issue #3238915: Refactor (if feasible) uses of the jQuery ready function to use VanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!957Added throwing of InvalidPluginDefinitionException from getDefinition().,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!873Issue #2875228: Site install not using batch API service,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!712Issue #2909128: Autocomplete intermittent on Chrome Android,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
...@@ -146,14 +146,13 @@ function (ConstraintViolation $v) { ...@@ -146,14 +146,13 @@ function (ConstraintViolation $v) {
* Tests using drupalMedia button to embed media into CKEditor 5. * Tests using drupalMedia button to embed media into CKEditor 5.
*/ */
public function testButton() { public function testButton() {
$this->markTestSkipped();
$media_preview_selector = '.ck-content .ck-widget.drupal-media .media'; $media_preview_selector = '.ck-content .ck-widget.drupal-media .media';
$this->drupalGet('/node/add/blog'); $this->drupalGet('/node/add/blog');
$this->waitForEditor(); $this->waitForEditor();
$this->pressEditorButton('Insert Drupal Media'); $this->pressEditorButton('Insert Drupal Media');
$assert_session = $this->assertSession(); $assert_session = $this->assertSession();
$page = $this->getSession()->getPage(); $page = $this->getSession()->getPage();
$this->assertNotEmpty($assert_session->waitForId('drupal-modal')); $this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-modal #media-library-content'));
// Ensure that the tab order is correct. // Ensure that the tab order is correct.
$tabs = $page->findAll('css', '.media-library-menu__link'); $tabs = $page->findAll('css', '.media-library-menu__link');
...@@ -194,7 +193,8 @@ public function testButton() { ...@@ -194,7 +193,8 @@ public function testButton() {
$this->drupalGet('/node/add/blog'); $this->drupalGet('/node/add/blog');
$this->waitForEditor(); $this->waitForEditor();
$this->pressEditorButton('Insert Drupal Media'); $this->pressEditorButton('Insert Drupal Media');
$assert_session->waitForElement('css', '.js-media-library-item')->click(); $this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-modal #media-library-content'));
$assert_session->elementExists('css', '.js-media-library-item')->click();
$assert_session->elementExists('css', '.ui-dialog-buttonpane')->pressButton('Insert selected'); $assert_session->elementExists('css', '.ui-dialog-buttonpane')->pressButton('Insert selected');
$this->assertNotEmpty($assert_session->waitForElementVisible('css', $media_preview_selector, 1000)); $this->assertNotEmpty($assert_session->waitForElementVisible('css', $media_preview_selector, 1000));
$xpath = new \DOMXPath($this->getEditorDataAsDom()); $xpath = new \DOMXPath($this->getEditorDataAsDom());
...@@ -245,7 +245,7 @@ public function testAllowedMediaTypes() { ...@@ -245,7 +245,7 @@ public function testAllowedMediaTypes() {
$this->pressEditorButton('Insert Drupal Media'); $this->pressEditorButton('Insert Drupal Media');
$assert_session = $this->assertSession(); $assert_session = $this->assertSession();
$this->assertNotEmpty($assert_session->waitForId('media-library-wrapper')); $this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-modal #media-library-wrapper'));
if (empty($allowed_media_types) || count($allowed_media_types) === 2) { if (empty($allowed_media_types) || count($allowed_media_types) === 2) {
$assert_session->elementExists('css', 'li.media-library-menu-image'); $assert_session->elementExists('css', 'li.media-library-menu-image');
...@@ -277,7 +277,7 @@ public function testAlt() { ...@@ -277,7 +277,7 @@ public function testAlt() {
$this->drupalGet('/node/add/blog'); $this->drupalGet('/node/add/blog');
$this->waitForEditor(); $this->waitForEditor();
$this->pressEditorButton('Insert Drupal Media'); $this->pressEditorButton('Insert Drupal Media');
$this->assertNotEmpty($assert_session->waitForId('drupal-modal')); $this->assertNotEmpty($assert_session->waitForElementVisible('css', '#drupal-modal #media-library-content'));
$assert_session->elementExists('css', '.js-media-library-item')->click(); $assert_session->elementExists('css', '.js-media-library-item')->click();
$assert_session->elementExists('css', '.ui-dialog-buttonpane')->pressButton('Insert selected'); $assert_session->elementExists('css', '.ui-dialog-buttonpane')->pressButton('Insert selected');
$this->assertNotEmpty($assert_session->waitForElementVisible('css', '.ck-widget.drupal-media img')); $this->assertNotEmpty($assert_session->waitForElementVisible('css', '.ck-widget.drupal-media img'));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment