Issue #2586013 by g-brodiei, pameeela, ayushmishra206, Vidushi Mehta, willzyx,... (bd8685e6) · Commits · project / drupal

core/modules/node/node.views.inc

0 → 100644

+52 −0

Original line number	Diff line number	Diff line
		<?php

		/**
		* @file
		* Provide views data for node.module.
		*/

		use Drupal\user\RoleInterface;
		use Drupal\views\ViewExecutable;
		use Drupal\user\Entity\Role;
		use Drupal\views\Analyzer;

		/**
		* Implements hook_views_analyze().
		*/
		function node_views_analyze(ViewExecutable $view) {
		$ret = [];
		// Check for something other than the default display:
		if ($view->storage->get('base_table') == 'node') {
		foreach ($view->displayHandlers as $display) {
		if (!$display->isDefaulted('access') \|\| !$display->isDefaulted('filters')) {
		// check for no access control
		$access = $display->getOption('access');
		if (empty($access['type']) \|\| $access['type'] == 'none') {
		$anonymous_role = Role::load(RoleInterface::ANONYMOUS_ID);
		$anonymous_has_access = $anonymous_role && $anonymous_role->hasPermission('access content');
		$authenticated_role = Role::load(RoleInterface::AUTHENTICATED_ID);
		$authenticated_has_access = $authenticated_role && $authenticated_role->hasPermission('access content');
		if (!$anonymous_has_access \|\| !$authenticated_has_access) {
		$ret[] = Analyzer::formatMessage(t('Some roles lack permission to access content, but display %display has no access control.', ['%display' => $display->display['display_title']]), 'warning');
		}
		$filters = $display->getOption('filters');
		foreach ($filters as $filter) {
		if ($filter['table'] == 'node' && ($filter['field'] == 'status' \|\| $filter['field'] == 'status_extra')) {
		continue 2;
		}
		}
		$ret[] = Analyzer::formatMessage(t('Display %display has no access control but does not contain a filter for published nodes.', ['%display' => $display->display['display_title']]), 'warning');
		}
		}
		}
		}
		foreach ($view->displayHandlers as $display) {
		if ($display->getPluginId() == 'page') {
		if ($display->getOption('path') == 'node/%') {
		$ret[] = Analyzer::formatMessage(t('Display %display has set node/% as path. This will not produce what you want. If you want to have multiple versions of the node view, use Layout Builder.', ['%display' => $display->display['display_title']]), 'warning');
		}
		}
		}

		return $ret;
		}

core/modules/node/node.views_execution.inc

+0 −43

Original line number	Diff line number	Diff line
		@@ -5,9 +5,7 @@
		* Provide views runtime hooks for node.module.
		*/

		use Drupal\user\RoleInterface;
		use Drupal\views\ViewExecutable;
		use Drupal\user\Entity\Role;

		/**
		* Implements hook_views_query_substitutions().
		@@ -20,44 +18,3 @@ function node_views_query_substitutions(ViewExecutable $view) {
		'*BYPASS_NODE_ACCESS*' => intval($account->hasPermission('bypass node access')),
		];
		}

		/**
		* Implements hook_views_analyze().
		*/
		function node_views_analyze(ViewExecutable $view) {
		$ret = [];
		// Check for something other than the default display:
		if ($view->storage->get('base_table') == 'node') {
		foreach ($view->displayHandlers as $display) {
		if (!$display->isDefaulted('access') \|\| !$display->isDefaulted('filters')) {
		// check for no access control
		$access = $display->getOption('access');
		if (empty($access['type']) \|\| $access['type'] == 'none') {
		$anonymous_role = Role::load(RoleInterface::ANONYMOUS_ID);
		$anonymous_has_access = $anonymous_role && $anonymous_role->hasPermission('access content');
		$authenticated_role = Role::load(RoleInterface::AUTHENTICATED_ID);
		$authenticated_has_access = $authenticated_role && $authenticated_role->hasPermission('access content');
		if (!$anonymous_has_access \|\| !$authenticated_has_access) {
		$ret[] = Analyzer::formatMessage(t('Some roles lack permission to access content, but display %display has no access control.', ['%display' => $display->display['display_title']]), 'warning');
		}
		$filters = $display->getOption('filters');
		foreach ($filters as $filter) {
		if ($filter['table'] == 'node' && ($filter['field'] == 'status' \|\| $filter['field'] == 'status_extra')) {
		continue 2;
		}
		}
		$ret[] = Analyzer::formatMessage(t('Display %display has no access control but does not contain a filter for published nodes.', ['%display' => $display->display['display_title']]), 'warning');
		}
		}
		}
		}
		foreach ($view->displayHandlers as $display) {
		if ($display->getPluginId() == 'page') {
		if ($display->getOption('path') == 'node/%') {
		$ret[] = Analyzer::formatMessage(t('Display %display has set node/% as path. This will not produce what you want. If you want to have multiple versions of the node view, use panels.', ['%display' => $display->display['display_title']]), 'warning');
		}
		}
		}

		return $ret;
		}

core/modules/node/tests/modules/node_test_views/test_views/views.view.test_node_views_analyze.yml

0 → 100644

+180 −0

Original line number	Diff line number	Diff line
		langcode: en
		status: true
		dependencies:
		module:
		- node
		- user
		id: test_node_views_analyze
		label: test_node_views_analyze
		module: views
		description: ''
		tag: ''
		base_table: node_field_data
		base_field: nid
		display:
		default:
		display_plugin: default
		id: default
		display_title: Master
		position: 0
		display_options:
		access:
		type: perm
		options:
		perm: 'access content'
		cache:
		type: tag
		options: { }
		query:
		type: views_query
		options:
		disable_sql_rewrite: false
		distinct: false
		replica: false
		query_comment: ''
		query_tags: { }
		exposed_form:
		type: basic
		options:
		submit_button: Apply
		reset_button: false
		reset_button_label: Reset
		exposed_sorts_label: 'Sort by'
		expose_sort_order: true
		sort_asc_label: Asc
		sort_desc_label: Desc
		pager:
		type: mini
		options:
		items_per_page: 10
		offset: 0
		id: 0
		total_pages: null
		expose:
		items_per_page: false
		items_per_page_label: 'Items per page'
		items_per_page_options: '5, 10, 25, 50'
		items_per_page_options_all: false
		items_per_page_options_all_label: '- All -'
		offset: false
		offset_label: Offset
		tags:
		previous: ‹‹
		next: ››
		style:
		type: default
		row:
		type: 'entity:node'
		options:
		view_mode: teaser
		fields:
		title:
		id: title
		table: node_field_data
		field: title
		entity_type: node
		entity_field: title
		label: ''
		alter:
		alter_text: false
		make_link: false
		absolute: false
		trim: false
		word_boundary: false
		ellipsis: false
		strip_tags: false
		html: false
		hide_empty: false
		empty_zero: false
		settings:
		link_to_entity: true
		plugin_id: field
		relationship: none
		group_type: group
		admin_label: ''
		exclude: false
		element_type: ''
		element_class: ''
		element_label_type: ''
		element_label_class: ''
		element_label_colon: true
		element_wrapper_type: ''
		element_wrapper_class: ''
		element_default_classes: true
		empty: ''
		hide_alter_empty: true
		click_sort_column: value
		type: string
		group_column: value
		group_columns: { }
		group_rows: true
		delta_limit: 0
		delta_offset: 0
		delta_reversed: false
		delta_first_last: false
		multi_type: separator
		separator: ', '
		field_api_classes: false
		filters:
		status:
		value: '1'
		table: node_field_data
		field: status
		plugin_id: boolean
		entity_type: node
		entity_field: status
		id: status
		expose:
		operator: ''
		operator_limit_selection: false
		operator_list: { }
		group: 1
		sorts:
		created:
		id: created
		table: node_field_data
		field: created
		order: DESC
		entity_type: node
		entity_field: created
		plugin_id: date
		relationship: none
		group_type: group
		admin_label: ''
		exposed: false
		expose:
		label: ''
		granularity: second
		title: test_node_views_analyze
		header: { }
		footer: { }
		empty: { }
		relationships: { }
		arguments: { }
		display_extenders: { }
		cache_metadata:
		max-age: -1
		contexts:
		- 'languages:language_content'
		- 'languages:language_interface'
		- url.query_args
		- 'user.node_grants:view'
		- user.permissions
		tags: { }
		page_1:
		display_plugin: page
		id: page_1
		display_title: Page
		position: 1
		display_options:
		display_extenders: { }
		path: node/%
		cache_metadata:
		max-age: -1
		contexts:
		- 'languages:language_content'
		- 'languages:language_interface'
		- url.query_args
		- 'user.node_grants:view'
		- user.permissions
		tags: { }

core/modules/node/tests/src/Functional/Views/NodeViewsAnalyzeTest.php

0 → 100644

+47 −0

Original line number	Diff line number	Diff line
		<?php

		namespace Drupal\Tests\node\Functional\Views;

		/**
		* Tests node_views_analyze().
		*
		* @group node
		*/
		class NodeViewsAnalyzeTest extends NodeTestBase {

		/**
		* {@inheritdoc}
		*/
		public static $modules = ['views_ui', 'node_test_views'];

		/**
		* {@inheritdoc}
		*/
		protected $defaultTheme = 'stark';

		/**
		* Views used by this test.
		*
		* @var array
		*/
		public static $testViews = ['test_node_views_analyze'];

		/**
		* Tests the implementation of node_views_analyze().
		*/
		public function testNodeViewsAnalyze() {
		// Create user with permission to view analyze message on views_ui.
		$admin_user = $this->createUser(['administer views']);

		$this->drupalLogin($admin_user);

		// Access to views analyze page.
		$this->drupalGet('admin/structure/views/nojs/analyze/test_node_views_analyze/page_1');

		// Should return 200 with correct permission.
		$this->assertSession()->statusCodeEquals(200);

		$this->assertSession()->responseContains('has set node/% as path. This will not produce what you want. If you want to have multiple versions of the node view, use Layout Builder.');
		}

		}