Skip to content
Snippets Groups Projects
Verified Commit b5faa5d0 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #2313073 by smustgrave, asad_ahmed, mrinalini9, Munavijayalakshmi,...

Issue #2313073 by smustgrave, asad_ahmed, mrinalini9, Munavijayalakshmi, Abhijith S, Lendude, alexpott: Views preview doesn't pass 0 to context filters

(cherry picked from commit 43ea903a)
parent 861205ad
No related branches found
No related tags found
24 merge requests!8506Draft: Issue #3456536 by ibrahim tameme,!5646Issue #3350972 by nod_: [random test failure]...,!5600Issue #3350972 by nod_: [random test failure]...,!5343Issue #3305066 by quietone, Rename RedirectLeadingSlashesSubscriber,!4350Issue #3307718: Implement xxHash for non-cryptographic use-cases,!3603#ISSUE 3346218 Add a different message on edit comment,!3555Issue #2473873: Views entity operations lack cacheability support, resulting in incorrect dropbuttons,!3494Issue #3327018 by Spokje, longwave, xjm, mondrake: Update PHPStan to 1.9.3 and...,!3410Issue #3340128: UserLoginForm::submitForm has some dead code,!3389Issue #3325184 by Spokje, andypost, xjm, smustgrave: $this->configFactory is...,!3381Issue #3332363: Refactor Claro's menus-and-lists stylesheet,!3307Issue #3326193: CKEditor 5 can grow past the viewport when there is a lot of content,!3236Issue #3332419: Refactor Claro's messages stylesheet,!3231Draft: Issue #3049525 by longwave, fougere, larowlan, kim.pepper, AaronBauman, Wim...,!3212Issue #3294003: Refactor Claro's entity-meta stylesheet,!3194Issue #3330981: Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated...",!3143Issue #3313342: [PHP 8.1] Deprecated function: strpos(): Passing null to parameter #1 LayoutBuilderUiCacheContext.php on line 28,!3024Issue #3307509: Empty option for views bulk form,!2972Issue #1845004: Replace custom password hashing library with PHP 5.5 password_hash(),!2719Issue #3110137: Remove Classy from core.,!2688Issue #3261452: [PP-1] Remove tracker module from core,!2437Issue #3238257 by hooroomoo, Wim Leers: Fragment link pointing to <textarea>...,!2296Issue #3100732: Allow specifying `meta` data on JSON:API objects,!1626Issue #3256642: Make life better for database drivers that extend another database driver
......@@ -40,7 +40,7 @@ public function form(array $form, FormStateInterface $form_state) {
'#default_value' => \Drupal::config('views.settings')->get('ui.always_live_preview'),
];
// Add the arguments textfield
// Add the arguments textfield.
$form['controls']['view_args'] = [
'#type' => 'textfield',
'#title' => $this->t('Preview with contextual filters:'),
......@@ -49,7 +49,7 @@ public function form(array $form, FormStateInterface $form_state) {
];
$args = [];
if (!$form_state->isValueEmpty('view_args')) {
if ($form_state->getValue('view_args', '') !== '') {
$args = explode('/', $form_state->getValue('view_args'));
}
......
......@@ -39,7 +39,15 @@ public function testPreviewContextual() {
]);
$this->assertSession()->elementsCount('xpath', $selector, 1);
$this->submitForm($edit = ['view_args' => '100'], 'Update preview');
$this->submitForm(['view_args' => '100'], 'Update preview');
// Test that area text and exposed filters are present and rendered.
$this->assertSession()->fieldExists('id');
$this->assertSession()->pageTextContains('Test header text');
$this->assertSession()->pageTextContains('Test footer text');
$this->assertSession()->pageTextContains('Test empty text');
$this->submitForm(['view_args' => '0'], 'Update preview');
// Test that area text and exposed filters are present and rendered.
$this->assertSession()->fieldExists('id');
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment