Commit b5c30c32 authored by catch's avatar catch
Browse files

fix: #3555527 Since symfony/dom-crawler 7.4: Disabling HTML5 parsing is... 

fix: #3555527 Since symfony/dom-crawler 7.4: Disabling HTML5 parsing is deprecated. Symfony 8 will unconditionally use the native HTML5 parser

By: longwave
By: andypost
(cherry picked from commit c9472457)
parent 00d7504c

core/.deprecation-ignore.txt

+0 −2
Original line number Diff line number Diff line
@@ -53,8 +53,6 @@ 
%The "cache.static" service is deprecated in drupal:11.3.0 and is removed from drupal:13.0.0. Use the cache.memory bin instead. See https://www.drupal.org/node/3546856%



# Symfony 7.4.

%Since symfony/browser-kit 7.4: Method "Symfony\\Component\\BrowserKit\\AbstractBrowser::useHtml5Parser\(\)" is deprecated. Symfony 8 will unconditionally use the native HTML5 parser.%

%Since symfony/dom-crawler 7.4: Disabling HTML5 parsing is deprecated. Symfony 8 will unconditionally use the native HTML5 parser.%

%Since symfony/http-foundation 7.4: Request::get\(\) is deprecated, use properties -.*attributes, query or request directly instead.%

%Since symfony/validator 7.4: Support for evaluating options in the base Constraint class is deprecated. Initialize properties in the constructor of Drupal\\(Core|ckeditor5|file)\\[^ ]+ instead.%

%Since symfony/validator 7.4: Support for passing the choices as the first argument to Drupal\\Core\\[^ ]+ is deprecated.%

core/.phpstan-baseline.php

+0 −7
Original line number Diff line number Diff line
@@ -47656,13 +47656,6 @@ 
	'count' => 1,

	'path' => __DIR__ . '/tests/Drupal/Tests/BrowserTestBase.php',

];

$ignoreErrors[] = [

	'message' => '#^Call to deprecated method useHtml5Parser\\(\\) of class Symfony\\\\Component\\\\BrowserKit\\\\AbstractBrowser\\:

since Symfony 7\\.4, Symfony 8 will unconditionally use the native HTML5 parser$#',

	'identifier' => 'method.deprecated',

	'count' => 1,

	'path' => __DIR__ . '/tests/Drupal/Tests/BrowserTestBase.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\Tests\\\\BrowserTestBase\\:\\:__construct\\(\\) overrides @final method PHPUnit\\\\Framework\\\\TestCase\\:\\:__construct\\(\\)\\.$#',

	'identifier' => 'method.parentMethodFinalByPhpDoc',

core/tests/Drupal/Tests/BrowserTestBase.php

+1 −3
Original line number Diff line number Diff line
@@ -284,9 +284,7 @@ protected function getDefaultDriverInstance() { 
    }



    if ($this->minkDefaultDriverClass === BrowserKitDriver::class) {

      $browser = new DrupalTestBrowser();

      $browser->useHtml5Parser(FALSE);

      $driver = new $this->minkDefaultDriverClass($browser);

      $driver = new $this->minkDefaultDriverClass(new DrupalTestBrowser());

    }

    elseif (is_array($this->minkDefaultDriverArgs)) {

      // Use ReflectionClass to instantiate class with received params.