Unverified Commit b02f8158 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3266308 by dww, murilohp, Vinodhini.E, alexpott, Kristen Pol:... 

Issue #3266308 by dww, murilohp, Vinodhini.E, alexpott, Kristen Pol: %extensions placeholder not extension names printed on the Status report warning about obsolete extensions
parent 39b12c46

core/modules/system/system.install

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ function system_requirements($phase) { 
      $requirements['obsolete_extensions'] = [

        'title' => t('Obsolete extensions enabled'),

        'value' => t('Obsolete extensions found: %extensions. Obsolete extensions are provided only so that they can be uninstalled cleanly. You should immediately uninstall these extensions since they may be removed in a future release.', [

          '%extension_list' => Markup::create(implode(', ', $obsolete_extensions_link_list)),

          '%extensions' => Markup::create(implode(', ', $obsolete_extensions_link_list)),

        ]),

        'severity' => REQUIREMENT_WARNING,

      ];

core/modules/system/tests/src/Functional/System/StatusTest.php

+18 −0
Original line number Diff line number Diff line
@@ -129,6 +129,24 @@ public function testStatusPage() { 
    $session->pageTextNotContains('Deprecated modules found: Deprecated module.');

    $this->assertSession()->elementNotExists('xpath', "//a[contains(@href, 'http://example.com/deprecated')]");



    // Make sure there are no warnings about obsolete modules.

    $session->pageTextNotContains('Obsolete extensions enabled');

    $session->pageTextNotContains('Obsolete extensions found: System obsolete status test.');



    // Install an obsolete module. Normally this isn't possible, so write to

    // configuration directly.

    $this->config('core.extension')->set('module.system_status_obsolete_test', 0)->save();

    $this->rebuildAll();

    $this->drupalGet('admin/reports/status');

    $session->pageTextContains('Obsolete extensions enabled');

    $session->pageTextContains('Obsolete extensions found: System obsolete status test.');



    // Make sure the warning is gone after uninstalling the module.

    $module_installer->uninstall(['system_status_obsolete_test']);

    $this->drupalGet('admin/reports/status');

    $session->pageTextNotContains('Obsolete extensions enabled');

    $session->pageTextNotContains('Obsolete extensions found: System obsolete status test.');



    // Install deprecated theme and confirm warning message is displayed.

    $theme_installer = \Drupal::service('theme_installer');

    $theme_installer->install(['test_deprecated_theme']);