Verified Commit ac8820e1 authored by godotislate's avatar godotislate
Browse files

task: #3582506 Connection::open() should have SensitiveParameter 

By: prudloff
By: adhershmnair
By: smustgrave
By: longwave
dquote>
parent b6aadece

core/lib/Drupal/Core/Database/Connection.php

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ public function __construct(object $connection, array $connection_options) { 
   * @return object

   *   A client connection object.

   */

  abstract public static function open(array &$connection_options = []);

  abstract public static function open(#[\SensitiveParameter] array &$connection_options = []);



  /**

   * Ensures that the client connection can be garbage collected.

core/modules/mysql/src/Driver/Database/mysql/Connection.php

+1 −1
Original line number Diff line number Diff line
@@ -98,7 +98,7 @@ public function __construct(Mysql $connection, array $connection_options) { 
  /**

   * {@inheritdoc}

   */

  public static function open(array &$connection_options = []) {

  public static function open(#[\SensitiveParameter] array &$connection_options = []) {

    // The DSN should use either a socket or a host/port.

    if (isset($connection_options['unix_socket'])) {

      $dsn = 'mysql:unix_socket=' . $connection_options['unix_socket'];

core/modules/mysqli/src/Driver/Database/mysqli/Connection.php

+1 −1
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ public function __construct( 
  /**

   * {@inheritdoc}

   */

  public static function open(array &$connection_options = []) {

  public static function open(#[\SensitiveParameter] array &$connection_options = []) {

    // Sets mysqli error reporting mode to report errors from mysqli function

    // calls and to throw mysqli_sql_exception for errors.

    // @see https://www.php.net/manual/en/mysqli-driver.report-mode.php

core/modules/pgsql/src/Driver/Database/pgsql/Connection.php

+1 −1
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ protected function setPrefix($prefix) { 
  /**

   * {@inheritdoc}

   */

  public static function open(array &$connection_options = []) {

  public static function open(#[\SensitiveParameter] array &$connection_options = []) {

    // Default to TCP connection on port 5432.

    if (empty($connection_options['port'])) {

      $connection_options['port'] = 5432;

core/modules/sqlite/src/Driver/Database/sqlite/Connection.php

+1 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ public function __construct(SqliteConnection $connection, array $connection_opti 
  /**

   * {@inheritdoc}

   */

  public static function open(array &$connection_options = []) {

  public static function open(#[\SensitiveParameter] array &$connection_options = []) {

    // Allow PDO options to be overridden.

    $connection_options += [

      'pdo' => [],