Commit ac05f3d0 authored by Gábor Hojtsy's avatar Gábor Hojtsy
Browse files

Issue #3264435 by catch, Spokje: Help topics and rest don't filter out... 

Issue #3264435 by catch, Spokje: Help topics and rest don't filter out deprecated modules when testing
parent 6c507c32

core/modules/help_topics/tests/src/Functional/HelpTopicsSyntaxTest.php

+2 −2
Original line number Diff line number Diff line
@@ -281,8 +281,8 @@ protected function listDirectories($type) { 
    // excluding test ones.

    $lister = \Drupal::service('extension.list.' . $type);

    foreach ($lister->getAllAvailableInfo() as $name => $info) {

      // Skip obsolete modules.

      if (isset($info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER]) && $info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::OBSOLETE) {

      // Skip obsolete and deprecated modules.

      if ($info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::OBSOLETE || $info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] === ExtensionLifecycle::DEPRECATED) {

        continue;

      }

      $path = $lister->getPath($name);

core/modules/rest/tests/src/Kernel/EntityResource/EntityResourceRestTestCoverageTest.php

+3 −2
Original line number Diff line number Diff line
@@ -41,12 +41,13 @@ protected function setUp(): void { 


    $all_modules = $this->container->get('extension.list.module')->getList();

    $stable_core_modules = array_filter($all_modules, function ($module) {

      // Filter out contrib, hidden, testing, and experimental modules. We also

      // don't need to enable modules that are already enabled.

      // Filter out contrib, hidden, testing, deprecated and experimental

      // modules. We also don't need to enable modules that are already enabled.

      return $module->origin === 'core' &&

        empty($module->info['hidden']) &&

        $module->status == FALSE &&

        $module->info['package'] !== 'Testing' &&

        $module->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] !== ExtensionLifecycle::DEPRECATED &&

        $module->info[ExtensionLifecycle::LIFECYCLE_IDENTIFIER] !== ExtensionLifecycle::EXPERIMENTAL;

    });