Commit a8ec5570 authored by catch's avatar catch
Browse files

Issue #3122113 by Suresh Prabhu Parkala, rpayanm, bbrala, ilgnerfagundes,... 

Issue #3122113 by Suresh Prabhu Parkala, rpayanm, bbrala, ilgnerfagundes, gabesullice, catch, alexpott, xjm: Convert all PHPDoc links targeting JSON:API contrib issues to target Drupal core issues
parent 1965c9cd

core/modules/jsonapi/jsonapi.api.php

+2 −2
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ 
 *

 * @see https://github.com/json-api/json-api/pull/1268

 * @see https://github.com/json-api/json-api/pull/1311

 * @see https://www.drupal.org/project/jsonapi/issues/2955020

 * @see https://www.drupal.org/project/drupal/issues/2955020

 *

 * By implementing revision support as a profile, the JSON:API module should be

 * maximally compatible with other systems.
@@ -117,7 +117,7 @@ 
 * It is not yet possible to request a collection of revisions. This is still

 * under development in issue [#3009588].

 *

 * @see https://www.drupal.org/project/jsonapi/issues/3009588.

 * @see https://www.drupal.org/project/drupal/issues/3009588.

 * @see https://tools.ietf.org/html/rfc5829

 * @see https://www.drupal.org/docs/8/modules/jsonapi/revisions

 *

core/modules/jsonapi/src/Access/EntityAccessChecker.php

+3 −3
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ 
 * @internal JSON:API maintains no PHP API. The API is the HTTP API. This class

 *   may change at any time and could break any dependencies on it.

 *

 * @see https://www.drupal.org/project/jsonapi/issues/3032787

 * @see https://www.drupal.org/project/drupal/issues/3032787

 * @see jsonapi.api.php

 */

class EntityAccessChecker {
@@ -238,7 +238,7 @@ public function checkEntityAccess(EntityInterface $entity, $operation, AccountIn 
   *

   * @todo: remove when a generic revision access API exists in Drupal core, and

   * also remove the injected "node" and "media" services.

   * @see https://www.drupal.org/project/jsonapi/issues/2992833#comment-12818386

   * @see https://www.drupal.org/project/drupal/issues/2992833#comment-12818386

   */

  protected function checkRevisionViewAccess(EntityInterface $entity, AccountInterface $account) {

    assert($entity instanceof RevisionableInterface);
@@ -257,7 +257,7 @@ protected function checkRevisionViewAccess(EntityInterface $entity, AccountInter 


      default:

        $reason = 'Only node and media revisions are supported by JSON:API.';

        $reason .= ' For context, see https://www.drupal.org/project/jsonapi/issues/2992833#comment-12818258.';

        $reason .= ' For context, see https://www.drupal.org/project/drupal/issues/2992833#comment-12818258.';

        $reason .= ' To contribute, see https://www.drupal.org/project/drupal/issues/2350939 and https://www.drupal.org/project/drupal/issues/2809177.';

        $access = AccessResult::neutral($reason);

    }

core/modules/jsonapi/src/Access/RelationshipFieldAccess.php

+1 −1
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ 
 * @internal JSON:API maintains no PHP API. The API is the HTTP API. This class

 *   may change at any time and could break any dependencies on it.

 *

 * @see https://www.drupal.org/project/jsonapi/issues/3032787

 * @see https://www.drupal.org/project/drupal/issues/3032787

 * @see jsonapi.api.php

 */

class RelationshipFieldAccess implements AccessInterface {

core/modules/jsonapi/src/Access/TemporaryQueryGuard.php

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ 
 * @see https://www.drupal.org/project/drupal/issues/2809177

 * @see https://www.drupal.org/project/drupal/issues/777578

 *

 * @see https://www.drupal.org/project/jsonapi/issues/3032787

 * @see https://www.drupal.org/project/drupal/issues/3032787

 * @see jsonapi.api.php

 */

class TemporaryQueryGuard {

core/modules/jsonapi/src/Context/FieldResolver.php

+3 −3
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ 
 * @internal JSON:API maintains no PHP API. The API is the HTTP API. This class

 *   may change at any time and could break any dependencies on it.

 *

 * @see https://www.drupal.org/project/jsonapi/issues/3032787

 * @see https://www.drupal.org/project/drupal/issues/3032787

 * @see jsonapi.api.php

 */

class FieldResolver {
@@ -544,7 +544,7 @@ protected function getInternalName($field_name, array $resource_types) { 
   */

  protected function isMemberFilterable($external_name, array $resource_types) {

    return array_reduce($resource_types, function ($carry, ResourceType $resource_type) use ($external_name) {

      // @todo: remove the next line and uncomment the following one in https://www.drupal.org/project/jsonapi/issues/3017047.

      // @todo: remove the next line and uncomment the following one in https://www.drupal.org/project/drupal/issues/3017047.

      return $carry ?: $external_name === 'id' || $resource_type->isFieldEnabled($resource_type->getInternalName($external_name));

      /*return $carry ?: in_array($external_name, ['id', 'type']) || $resource_type->isFieldEnabled($resource_type->getInternalName($external_name));*/

    }, FALSE);
@@ -646,7 +646,7 @@ protected static function getDataReferencePropertyName(array $candidate_definiti 
        $prior_parts = array_slice($unresolved_path_parts, 0, count($unresolved_path_parts) - count($remaining_parts));

        return implode('.', array_merge($prior_parts, [$reference_name], $remaining_parts));

      }, $unique_reference_names);

      // @todo Add test coverage for this in https://www.drupal.org/project/jsonapi/issues/2971281

      // @todo Add test coverage for this in https://www.drupal.org/project/drupal/issues/2971281

      $message = sprintf('Ambiguous path. Try one of the following: %s, in place of the given path: %s', implode(', ', $choices), implode('.', $unresolved_path_parts));

      $cacheability = (new CacheableMetadata())->addCacheContexts(['url.query_args:filter', 'url.query_args:sort']);

      throw new CacheableBadRequestHttpException($cacheability, $message);