Issue #3307694 by smustgrave, pooja saraah, Amber Himes Matz: Update internal...

Issue #3307694 by smustgrave, pooja saraah, Amber Himes Matz: Update internal links in forum help topics to use help_route_link_function

(cherry picked from commit 6af6c55b)

core/modules/help_topics/help_topics/forum.configuring.html.twig

@@ -3,21 +3,24 @@ label: 'Configuring forums'
 related:
   - forum.concept
 ---
-{% set settings = render_var(url('forum.settings')) %}
-{% set overview = render_var(url('forum.overview')) %}
 {% set forum_concept_topic = render_var(help_topic_link('forum.concept')) %}
-{% set index = render_var(url('forum.index')) %}
+{% set settings_link_text %}{% trans %}Settings{% endtrans %}{% endset %}
+{% set settings_link = render_var(help_route_link(settings_link_text, 'forum.settings')) %}
+{% set overview_link_text %}{% trans %}Forums{% endtrans %}{% endset %}
+{% set overview_link = render_var(help_route_link(overview_link_text, 'forum.overview')) %}
+{% set index_link_text %}{% trans %}Forums{% endtrans %}{% endset %}
+{% set index_link = render_var(help_route_link(index_link_text, 'forum.index')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Configure settings for forums, and set up forum structure.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Structure</em> &gt; <em>Forums</em> &gt; <a href="{{ settings }}"><em>Settings</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Structure</em> &gt; <em>Forums</em> &gt; <em>{{ settings_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Choose the desired settings for <em>Hot topic threshold</em>, <em>Topics per page</em>, and <em>Default order</em>. Click <em>Save configuration</em> if you have made any changes.{% endtrans %}</li>
-  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Structure</em> &gt; <a href="{{ overview }}"><em>Forums</em></a>.{% endtrans %}</li>
+  <li>{% trans %}In the <em>Manage</em> administrative menu, navigate to <em>Structure</em> &gt; <em>{{ overview_link }}</em>.{% endtrans %}</li>
   <li>{% trans %}Decide on the hierarchy of containers and forums you want for your site; see {{ forum_concept_topic }} for an overview of forum hierarchy.{% endtrans %}</li>
   <li>{% trans %}Create the containers that you want in your forum hierarchy, starting at the top level, if any. To create a container, click <em>Add container</em>, enter the container name and optionally other settings, and click <em>Save</em>.{% endtrans %}</li>
   <li>{% trans %}Create the forums that you want in your forum hierarchy, starting at the top level. To create a forum, click <em>Add forum</em> and enter the forum name. If your hierarchy has this forum inside a container or another forum, select the parent forum/container in the <em>Parent</em> field. Review and/or edit the other settings, and click <em>Save</em>.{% endtrans %}</li>
   <li>{% trans %}Optionally, delete the provided <em>General discussion</em> forum, if you do not want this forum to be available on your site.{% endtrans %}</li>
   <li>{% trans %}Review and/or edit the permissions related to forums. The administrative permission for editing the forum settings is in the <em>Forum</em> module section of the permissions page, and administrative permissions for editing the forum hierarchy are in the <em>Taxonomy</em> module section. The user permissions for creating forum topics are in the <em>Node</em> module section, and for commenting on topics are in the <em>Comment</em> module section.{% endtrans %}</li>
-  <li>{% trans %}Add links to the main <a href="{{ index }}"><em>Forums</em></a> page (path: <em>/forum</em>), and optionally to individual forum pages, to navigation menus on your site, so that users can find the forums.{% endtrans %}</li>
+  <li>{% trans %}Add links to the main <em>{{ index_link }}</em> page (path: <em>/forum</em>), and optionally to individual forum pages, to navigation menus on your site, so that users can find the forums.{% endtrans %}</li>
 </ol>

core/modules/help_topics/help_topics/forum.locking.html.twig

@@ -3,12 +3,13 @@ label: 'Locking a forum topic'
 related:
   - forum.concept
 ---
-{% set index = render_var(url('forum.index')) %}
+{% set index_link_text %}{% trans %}Forums{% endtrans %}{% endset %}
+{% set index_link = render_var(help_route_link(index_link_text, 'forum.index')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Lock a topic to prevent users from making any more comments.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}Starting from the <a href="{{ index }}">forums page</a>, navigate to the forum that currently contains the topic.{% endtrans %}</li>
+  <li>{% trans %}Starting from {{ index_link }} (path: <em>/forums</em>), navigate to the forum that currently contains the topic.{% endtrans %}</li>
   <li>{% trans %}Locate the topic within the forum, and click on the title to view the topic.{% endtrans %}</li>
   <li>{% trans %}Click <em>Edit</em>.{% endtrans %}</li>
   <li>{% trans %}Under <em>Comment settings</em>, check <em>Closed</em>.{% endtrans %}</li>

core/modules/help_topics/help_topics/forum.moving.html.twig

@@ -3,12 +3,13 @@ label: 'Moving a topic to a new forum'
 related:
   - forum.concept
 ---
-{% set index = render_var(url('forum.index')) %}
+{% set index_link_text %}{% trans %}Forums{% endtrans %}{% endset %}
+{% set index_link = render_var(help_route_link(index_link_text, 'forum.index')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Move a forum topic and all of its comments to a new forum. {% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}Starting from the <a href="{{ index }}">forums page</a>, navigate to the forum that currently contains the topic.{% endtrans %}</li>
+  <li>{% trans %}Starting from {{ index_link }} (path: <em>/forums</em>), navigate to the forum that currently contains the topic.{% endtrans %}</li>
   <li>{% trans %}Locate the topic within the forum, and click on the title to view the topic.{% endtrans %}</li>
   <li>{% trans %}Click <em>Edit</em>.{% endtrans %}</li>
   <li>{% trans %}In the <em>Forums</em> field, select the new forum that you want the topic to move to.{% endtrans %}</li>

core/modules/help_topics/help_topics/forum.starting.html.twig

@@ -3,12 +3,13 @@ label: 'Starting a forum discussion'
 related:
   - forum.concept
 ---
-{% set index = render_var(url('forum.index')) %}
+{% set index_link_text %}{% trans %}Forums{% endtrans %}{% endset %}
+{% set index_link = render_var(help_route_link(index_link_text, 'forum.index')) %}
 <h2>{% trans %}Goal{% endtrans %}</h2>
 <p>{% trans %}Post a new topic in a forum to start a discussion.{% endtrans %}</p>
 <h2>{% trans %}Steps{% endtrans %}</h2>
 <ol>
-  <li>{% trans %}Starting from the <a href="{{ index }}">forums page</a>, navigate to the forum where you want to post the topic.{% endtrans %}</li>
+  <li>{% trans %}Starting from {{ index_link }} (path: <em>/forums</em>), navigate to the forum that currently contains the topic.{% endtrans %}</li>
   <li>{% trans %}Click <em>Add new Forum topic</em>.{% endtrans %}</li>
   <li>{% trans %}Enter the topic's <em>Subject</em> and <em>Body</em>.{% endtrans %}</li>
   <li>{% trans %}Click <em>Save</em>.{% endtrans %}</li>