Verified Commit a2f2ac96 authored by Dave Long's avatar Dave Long
Browse files

Revert "Issue #3272629 by kelly.m.jacobs, alexpott, Abhijith S, imclean,... 

Revert "Issue #3272629 by kelly.m.jacobs, alexpott, Abhijith S, imclean, heni_deepak, azinck: Media Library widget display doesn't return to first page on applying filters"

This reverts commit 09af9754.
parent a708e542

core/modules/media_library/media_library.module

+0 −2
Original line number Diff line number Diff line
@@ -214,8 +214,6 @@ function media_library_views_post_render(ViewExecutable $view, &$output, CachePl 
        $ajax_path = &$output['#attached']['drupalSettings']['views']['ajax_path'];

        $parsed_url = UrlHelper::parse($ajax_path);

        $query = array_merge($query, $parsed_url['query']);

        // Reset the pager so that the user starts on the first page.

        unset($query['page']);

        $ajax_path = $parsed_url['path'] . '?' . UrlHelper::buildQuery($query);

      }

    }

core/modules/media_library/tests/src/FunctionalJavascript/WidgetViewsTest.php

+2 −19
Original line number Diff line number Diff line
@@ -116,25 +116,7 @@ public function testWidgetViews() { 
    $assert_session->pageTextContains('Bear');

    $assert_session->pageTextNotContains('Turtle');



    // Assert the exposed filters can be applied and page is reset from second

    // page.

    $page->clickLink('Next page');

    $this->waitForElementTextContains('.js-media-library-view .js-pager__items > li:nth-of-type(2)', 'Page 2');

    $page->fillField('Name', 'Bear');

    $page->pressButton('Apply filters');

    $assert_session->assertWaitOnAjaxRequest();

    $assert_session->pageTextNotContains('Dog');

    $assert_session->pageTextContains('Bear');

    $assert_session->pageTextNotContains('Turtle');



    // Test clearing the filters.

    $page->fillField('Name', '');

    $page->pressButton('Apply filters');

    $assert_session->waitForLink('Next page');

    $page->clickLink('Next page');

    $this->waitForElementTextContains('.js-media-library-view .js-pager__items > li:nth-of-type(2)', 'Page 2');



    // Assert the exposed filters are persisted when changing display.

    // Assert the exposed filters can be applied.

    $page->fillField('Name', 'Dog');

    $page->pressButton('Apply filters');

    $assert_session->assertWaitOnAjaxRequest();
@@ -145,6 +127,7 @@ public function testWidgetViews() { 
    $assert_session->linkExists('Table');

    $this->switchToMediaLibraryGrid();



    // Assert the exposed filters are persisted when changing display.

    $this->assertSame('Dog', $page->findField('Name')->getValue());

    $assert_session->pageTextContains('Dog');

    $assert_session->pageTextNotContains('Crocodile');