Skip to content
Snippets Groups Projects
Verified Commit a0138ae5 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #2833116 by smustgrave, mohit_aghera, Ratan Priya, _pratik_, _shY,...

Issue #2833116 by smustgrave, mohit_aghera, Ratan Priya, _pratik_, _shY, alexpott, nitin_lama, acbramley, quietone, larowlan, Peter van den Heuvel, ameymudras, alexpott: When Placing a Block on 'Configure Block' page the originally selected region is lost

(cherry picked from commit 1f94e17f)
parent 7f5ab910
No related branches found
No related tags found
35 merge requests!12802Issue #3537193 by opauwlo: Add enable absolute path option for CKEditor5 image uploads,!12745Fixed: Path alias language doesn't changes on changing of node language,!12684Issue #3220784,!12537Add ViewsConfigUpdater deprecation support for default_argument_skip_url,!12523Issue #3493858 by vidorado, xavier.masson, smustgrave: Extend ViewsBlockBase...,!122353526426-warning-for-missing,!12212Issue #3445525 by alexpott, japerry, catch, mglaman, longwave: Add BC layer...,!11958Issue #3490507 by alexpott, smustgrave: Fix bogus mocking in...,!11769Issue #3517987: Add option to contextual filters to encode slashes in query parameter.,!11185Issue #3477324 by andypost, alexpott: Fix usage of str_getcsv() and fgetcsv() for PHP 8.4,!10602Issue #3438769 by vinmayiswamy, antonnavi, michelle, amateescu: Sub workspace does not clear,!10301Issue #3469309 by mstrelan, smustgrave, moshe weitzman: Use one-time login...,!10187Issue #3487488 by dakwamine: ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip,!9944Issue #3483353: Consider making the createCopy config action optionally fail...,!9929Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9787Resolve issue 3479427 - bootstrap barrio issue under Windows,!9742Issue #3463908 by catch, quietone: Split OptionsFieldUiTest into two,!9526Issue #3458177 by mondrake, catch, quietone, godotislate, longwave, larowlan,...,!8738Issue #3424162 by camilledavis, dineshkumarbollu, smustgrave: Claro...,!8704Make greek characters available in ckeditor5,!8597Draft: Issue #3442259 by catch, quietone, dww: Reduce time of Migrate Upgrade tests...,!8533Issue #3446962 by kim.pepper: Remove incorrectly added...,!8517Issue #3443748 by NexusNovaz, smustgrave: Testcase creates false positive,!8325Update file Sort.php,!8095Expose document root on install,!7930Resolve #3427374 "Taxonomytid viewsargumentdefault plugin",!7627Issue #3439440 by nicxvan, Binoli Lalani, longwave: Remove country support from DateFormatter,!7445Issue #3440169: When using drupalGet(), provide an associative array for $headers,!7401#3271894 Fix documented StreamWrapperInterface return types for realpath() and dirname(),!7384Add constraints to system.advisories,!7078Issue #3320569 by Spokje, mondrake, smustgrave, longwave, quietone, Lendude,...,!6622Issue #2559833 by piggito, mohit_aghera, larowlan, guptahemant, vakulrai,...,!6502Draft: Resolve #2938524 "Plach testing issue",!38582585169-10.1.x,!3226Issue #2987537: Custom menu link entity type should not declare "bundle" entity key
Pipeline #121149 passed
Pipeline: drupal

#121165

    Pipeline: drupal

    #121163

      Pipeline: drupal

      #121158

        +1
        ......@@ -115,6 +115,7 @@ public function save(array $form, FormStateInterface $form_state) {
        [
        'plugin_id' => 'block_content:' . $block->uuid(),
        'theme' => $theme,
        'region' => $this->getRequest()->query->getString('region'),
        ]
        );
        }
        ......
        ......@@ -4,13 +4,42 @@
        use Drupal\Core\Menu\LocalActionDefault;
        use Drupal\Core\Routing\RouteMatchInterface;
        use Drupal\Core\Routing\RouteProviderInterface;
        use Drupal\Core\Url;
        use Symfony\Component\DependencyInjection\ContainerInterface;
        use Symfony\Component\HttpFoundation\RequestStack;
        /**
        * Modifies the 'Add content block' local action.
        */
        class BlockContentAddLocalAction extends LocalActionDefault {
        /**
        * Constructs a BlockContentAddLocalAction object.
        */
        public function __construct(
        array $configuration,
        $plugin_id,
        $plugin_definition,
        RouteProviderInterface $routeProvider,
        protected RequestStack $requestStack,
        ) {
        parent::__construct($configuration, $plugin_id, $plugin_definition, $routeProvider);
        }
        /**
        * {@inheritdoc}
        */
        public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
        return new static(
        $configuration,
        $plugin_id,
        $plugin_definition,
        $container->get('router.route_provider'),
        $container->get('request_stack'),
        );
        }
        /**
        * {@inheritdoc}
        */
        ......@@ -20,6 +49,12 @@ public function getOptions(RouteMatchInterface $route_match) {
        if ($theme = $route_match->getParameter('theme')) {
        $options['query']['theme'] = $theme;
        }
        // If the current request has a region, append it to the query string.
        if ($region = $this->requestStack->getCurrentRequest()->query->getString('region')) {
        $options['query']['region'] = $region;
        }
        // Adds a destination on content block listing.
        if ($route_match->getRouteName() == 'entity.block_content.collection') {
        $options['query']['destination'] = Url::fromRoute('<current>')->toString();
        ......
        ......@@ -71,6 +71,22 @@ protected function setUp(): void {
        ]);
        }
        /**
        * Tests the region value when a new block is saved.
        */
        public function testBlockRegionPlacement(): void {
        $this->drupalLogin($this->drupalCreateUser($this->permissions));
        $this->drupalGet("admin/structure/block/library/stark", ['query' => ['region' => 'content']]);
        $this->clickLink('Add content block');
        $this->assertSession()->statusCodeEquals(200);
        $edit = [
        'info[0][value]' => 'foo',
        ];
        $this->submitForm($edit, 'Save');
        $this->assertSession()->fieldValueEquals('region', 'content');
        }
        /**
        * Tests the content block listing page with different permissions.
        */
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Please register or to comment