Skip to content
Snippets Groups Projects
Verified Commit 9e2ca2c7 authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3467821 by catch, smustgrave: Remove a couple of data providers from ckeditor5 ImageTestBase

(cherry picked from commit d7bb4b3b)
parent aea2e68e
Branches
Tags
17 merge requests!10663Issue #3495778: Update phpdoc in FileSaveHtaccessLoggingTest,!10451Issue #3472458 by watergate, smustgrave: CKEditor 5 show blocks label is not translated,!103032838547 Fix punctuation rules for inline label suffix colon with CSS only,!10150Issue #3467294 by quietone, nod_, smustgrave, catch, longwave: Change string...,!10130Resolve #3480321 "Second level menu",!9936Issue #3483087: Check the module:// prefix in the translation server path and replace it with the actual module path,!9933Issue #3394728 by ankondrat4: Undefined array key "#prefix" and deprecated function: explode() in Drupal\file\Element\ManagedFile::uploadAjaxCallback(),!9914Issue #3451136 by quietone, gapple, ghost of drupal past: Improve...,!9882Draft: Issue #3481777 In bulk_form ensure the triggering element is the bulk_form button,!9839Issue #3445469 by pooja_sharma, smustgrave: Add additional test coverage for...,!9815Issue #3480025: There is no way to remove entity cache items,!9757Issue #3478869 Add "All" or overview links to parent links,!9752Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9749Issue #3439910 by pooja_sharma, vensires: Fix Toolbar tests that rely on UID1's super user behavior,!9678Issue #3465132 by catch, Spokje, nod_: Show test run time by class in run-tests.sh output,!9578Issue #3304746 by scott_euser, casey, smustgrave: BigPipe cannot handle (GET)...,!9449Issue #3344041: Allow textarea widgets to be used for text (formatted) fields
Pipeline #254215 canceled
Pipeline: drupal

#254217

    ......@@ -359,15 +359,21 @@ public function testLinkability(): void {
    }
    }
    /**
    * Tests that alt text is required for images.
    */
    public function testAltTextRequired() {
    foreach ([FALSE, TRUE] as $unrestricted) {
    $this->doTestAltTextRequired($unrestricted);
    }
    }
    /**
    * Tests that alt text is required for images.
    *
    * @see https://ckeditor.com/docs/ckeditor5/latest/framework/guides/architecture/editing-engine.html#conversion
    *
    * @dataProvider providerAltTextRequired
    */
    public function testAltTextRequired(bool $unrestricted): void {
    // Disable filter_html.
    protected function doTestAltTextRequired(bool $unrestricted): void {
    if ($unrestricted) {
    FilterFormat::load('test_format')
    ->setFilterConfig('filter_html', ['status' => FALSE])
    ......@@ -380,7 +386,7 @@ public function testAltTextRequired(bool $unrestricted): void {
    'width="500"',
    '<img ' . $this->imageAttributesAsString() . ' />'
    );
    $this->host->body->value .= $img_tag . "<p>$img_tag</p>";
    $this->host->body->value = "<p>I'm a pirate</p>" . $img_tag . "<p>$img_tag</p>";
    $this->host->save();
    $page = $this->getSession()->getPage();
    ......@@ -455,13 +461,6 @@ public function testAltTextRequired(bool $unrestricted): void {
    $this->assertVisibleBalloon('.ck-text-alternative-form');
    }
    public static function providerAltTextRequired(): array {
    return [
    'Restricted' => [FALSE],
    'Unrestricted' => [TRUE],
    ];
    }
    protected function providerLinkability(): array {
    return [
    'BLOCK image, restricted' => ['block', FALSE],
    ......@@ -473,15 +472,22 @@ protected function providerLinkability(): array {
    /**
    * Tests alignment integration.
    *
    * @dataProvider providerAlignment
    */
    public function testAlignment(string $image_type): void {
    public function testAlignment() {
    foreach (['block', 'inline'] as $image_type) {
    $this->doTestAlignment($image_type);
    }
    }
    /**
    * Tests alignment integration.
    */
    protected function doTestAlignment(string $image_type): void {
    $assert_session = $this->assertSession();
    $page = $this->getSession()->getPage();
    // Make the test content have either a block image or an inline image.
    $img_tag = '<img alt="drupalimage test image" ' . $this->imageAttributesAsString() . ' />';
    $this->host->body->value .= $image_type === 'block'
    $this->host->body->value = "<p>I'm a pirate</p>" . $image_type === 'block'
    ? $img_tag
    : "<p>$img_tag</p>";
    $this->host->save();
    ......@@ -533,22 +539,22 @@ public function testAlignment(string $image_type): void {
    $this->assertFalse($drupal_media_element->hasAttribute('data-align'));
    }
    public static function providerAlignment() {
    return [
    'Block image' => ['block'],
    'Inline image' => ['inline'],
    ];
    /**
    * Ensures that width attribute upcasts and downcasts correctly.
    */
    public function testWidth() {
    foreach (static::providerWidth() as $data) {
    $this->doTestWidth($data['width']);
    }
    }
    /**
    * Ensures that width attribute upcasts and downcasts correctly.
    * Tests the width attribute with different widths.
    *
    * @param string $width
    * The width input for the image.
    *
    * @dataProvider providerWidth
    */
    public function testWidth(string $width): void {
    protected function doTestWidth(string $width): void {
    $page = $this->getSession()->getPage();
    $assert_session = $this->assertSession();
    ......@@ -641,13 +647,20 @@ public static function providerWidth(): array {
    *
    * Confirms that enabling the resize plugin introduces the resize class to
    * images within CKEditor 5.
    */
    public function testResize() {
    foreach ([TRUE, FALSE] as $is_resize_enabled) {
    $this->doTestResize($is_resize_enabled);
    }
    }
    /**
    * Tests the image resize plugin.
    *
    * @param bool $is_resize_enabled
    * Boolean flag to test enabled or disabled.
    *
    * @dataProvider providerResize
    */
    public function testResize(bool $is_resize_enabled): void {
    protected function doTestResize(bool $is_resize_enabled): void {
    // Disable resize plugin because it is enabled by default.
    if (!$is_resize_enabled) {
    Editor::load('test_format')->setSettings([
    ......@@ -673,21 +686,4 @@ public function testResize(bool $is_resize_enabled): void {
    $this->assertSame($is_resize_enabled, $image_figure->hasClass('ck-widget_with-resizer'));
    }
    /**
    * Data provider for ::testResize().
    *
    * @return array
    * The test cases.
    */
    public static function providerResize(): array {
    return [
    'Image resize is enabled' => [
    'is_resize_enabled' => TRUE,
    ],
    'Image resize is disabled' => [
    'is_resize_enabled' => FALSE,
    ],
    ];
    }
    }
    0% Loading or .
    You are about to add 0 people to the discussion. Proceed with caution.
    Please register or to comment