Verified Commit 9e0897a7 authored by quietone's avatar quietone
Browse files

Issue #3487666 by mstrelan, nicxvan: Add void return type to all *_alter hook implementations 

(cherry picked from commit 55fd8379)
parent 0922e415

core/.phpstan-baseline.php

+0 −1482

File changed.

Preview size limit exceeded, changes collapsed.

core/modules/announcements_feed/src/Hook/AnnouncementsFeedHooks.php

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ public function toolbar() { 
   * Implements hook_toolbar_alter().

   */

  #[Hook('toolbar_alter')]

  public function toolbarAlter(&$items) {

  public function toolbarAlter(&$items): void {

    // As the "Announcements" link is shown already in the top toolbar bar, we

    // don't need it again in the administration menu tray, so hide it.

    if (!empty($items['administration']['tray'])) {

core/modules/big_pipe/tests/modules/big_pipe_bypass_js/src/Hook/BigPipeBypassJsHooks.php

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ class BigPipeBypassJsHooks { 
   * Disables Big Pipe JavaScript by removing the js file from the library.

   */

  #[Hook('library_info_alter')]

  public function libraryInfoAlter(&$libraries, $extension) {

  public function libraryInfoAlter(&$libraries, $extension): void {

    if ($extension === 'big_pipe') {

      unset($libraries['big_pipe']['js']);

    }

core/modules/block/src/Hook/BlockHooks.php

+1 −1
Original line number Diff line number Diff line
@@ -186,7 +186,7 @@ public function configurableLanguageDelete(ConfigurableLanguageInterface $langua 
   * Implements hook_block_build_BASE_BLOCK_ID_alter().

   */

  #[Hook('block_build_local_actions_block_alter')]

  public function blockBuildLocalActionsBlockAlter(array &$build, BlockPluginInterface $block) {

  public function blockBuildLocalActionsBlockAlter(array &$build, BlockPluginInterface $block): void {

    $build['#lazy_builder_preview'] = [

      '#type' => 'container',

      '#attributes' => [

core/modules/block/tests/modules/block_test/src/Hook/BlockTestHooks.php

+3 −3
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ class BlockTestHooks { 
   * Implements hook_block_alter().

   */

  #[Hook('block_alter')]

  public function blockAlter(&$block_info) {

  public function blockAlter(&$block_info): void {

    if (\Drupal::state()->get('block_test_info_alter') && isset($block_info['test_block_instantiation'])) {

      $block_info['test_block_instantiation']['category'] = t('Custom category');

    }
@@ -27,7 +27,7 @@ public function blockAlter(&$block_info) { 
   * Implements hook_block_view_BASE_BLOCK_ID_alter().

   */

  #[Hook('block_view_test_cache_alter')]

  public function blockViewTestCacheAlter(array &$build, BlockPluginInterface $block) {

  public function blockViewTestCacheAlter(array &$build, BlockPluginInterface $block): void {

    if (\Drupal::state()->get('block_test_view_alter_suffix') !== NULL) {

      $build['#attributes']['foo'] = 'bar';

    }
@@ -40,7 +40,7 @@ public function blockViewTestCacheAlter(array &$build, BlockPluginInterface $blo 
   * Implements hook_block_build_BASE_BLOCK_ID_alter().

   */

  #[Hook('block_build_test_cache_alter')]

  public function blockBuildTestCacheAlter(array &$build, BlockPluginInterface $block) {

  public function blockBuildTestCacheAlter(array &$build, BlockPluginInterface $block): void {

    // Test altering cache keys, contexts, tags and max-age.

    if (\Drupal::state()->get('block_test_block_alter_cache_key') !== NULL) {

      $build['#cache']['keys'][] = \Drupal::state()->get('block_test_block_alter_cache_key');