Verified Commit 9afec8fa authored by godotislate's avatar godotislate
Browse files

task: #3585957 Prevent the navigation sidebar being rendered via big pipe 

By: catch
By: godotislate
parent 8a9850a4

core/modules/navigation/src/NavigationRenderer.php

+5 −0
Changes for core/modules/navigation/src/NavigationRenderer.php: 5 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -86,6 +86,11 @@ public function buildNavigation(array &$page_top): void { 
      ],

      '#lazy_builder' => ['navigation.renderer:doBuildNavigation', []],

      '#create_placeholder' => TRUE,

      // Prevent this placeholder being handled by Big Pipe.

      // @todo remove in https://www.drupal.org/project/drupal/issues/3505610

      '#placeholder_strategy_denylist' => [

        BigPipeStrategy::class => TRUE,

      ],

    ];

  }

core/profiles/demo_umami/tests/src/FunctionalJavascript/MultipleRequestsPerformanceTestAssertions/umamiNodeAddEditor.yml

+1 −1
Changes for core/profiles/demo_umami/tests/src/FunctionalJavascript/MultipleRequestsPerformanceTestAssertions/umamiNodeAddEditor.yml: 1 added line, 1 removed line.
Original line number Diff line number Diff line 
ScriptCount: 20

ScriptBytes: 2963979

StylesheetCount: 27

StylesheetCount: 26

StylesheetBytes: 640664

core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryPerformanceTestAssertions/administratorNodePage.yml

+16 −16
Changes for core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryPerformanceTestAssertions/administratorNodePage.yml: 16 added lines, 16 removed lines.
Original line number Diff line number Diff line 
QueryCount: 266

CacheGetCount: 262

QueryCount: 264

CacheGetCount: 259

CacheGetCountByBin:

  config: 55

  bootstrap: 15

  discovery: 86

  data: 14

  data: 13

  entity: 24

  dynamic_page_cache: 1

  default: 8

  routes: 18

  routes: 16

  render: 17

  file_parsing: 2

  menu: 22

CacheSetCount: 270

CacheSetCount: 267

CacheDeleteCount: 0

CacheTagInvalidationCount: 0

CacheTagLookupQueryCount: 30
@@ -86,6 +86,16 @@ CacheTagGroupedLookups: 
    - 'config:system.menu.admin'

  -

    - 'config:system.menu.'

  -

    - 'config:navigation.block_layout'

    - 'config:navigation.settings'

    - 'config:node_type_list'

  -

    - 'config:system.menu.navigation-user-links'

  -

    - 'config:user.role.authenticated'

    - 'config:user.role.test_admin'

    - 'user:11'

  -

    - 'config:system.menu.account'

  -
@@ -112,16 +122,6 @@ CacheTagGroupedLookups: 
    - 'taxonomy_term:8'

    - 'taxonomy_term:9'

    - taxonomy_term_list

  -

    - 'config:navigation.block_layout'

    - 'config:navigation.settings'

    - 'config:node_type_list'

  -

    - 'config:system.menu.navigation-user-links'

  -

    - 'config:user.role.authenticated'

    - 'config:user.role.test_admin'

    - 'user:11'

  -

    - 'config:image.style.medium_8_7'

    - 'file:37'
@@ -130,5 +130,5 @@ CacheTagGroupedLookups: 
    - block_content_view

ScriptCount: 12

ScriptBytes: 187160

StylesheetCount: 12

StylesheetCount: 11

StylesheetBytes: 73614