Skip to content
Snippets Groups Projects
Verified Commit 96c70753 authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3517317 by penyaskito, larowlan: SDC slots not being validated against json config schema

parent b864f09b
No related branches found
No related tags found
No related merge requests found
Pipeline #465184 passed with warnings
Pipeline: drupal

#465201

    Pipeline: drupal

    #465198

      Pipeline: drupal

      #465189

        ......@@ -5,7 +5,7 @@
        "slotDefinition": {
        "type": "object",
        "patternProperties": {
        "^[a-zA-Z0-9_-]$": {
        "^[a-zA-Z0-9_-]+$": {
        "type": "object",
        "properties": {
        "title": {
        ......
        ......@@ -5,7 +5,7 @@
        "slotDefinition": {
        "type": "object",
        "patternProperties": {
        "^[a-zA-Z0-9_-]$": {
        "^[a-zA-Z0-9_-]+$": {
        "type": "object",
        "properties": {
        "title": {
        ......
        ......@@ -102,6 +102,22 @@ public static function dataProviderValidateDefinitionInvalid(): \Generator {
        // allowed as the allowed type.
        $cta_with_non_string_prop_type['props']['properties']['text']['type'] = ['string', []];
        yield 'non string type (Array)' => [$cta_with_non_string_prop_type];
        $cta_with_invalid_slot_type = $valid_cta;
        $cta_with_invalid_slot_type['slots'] = [
        'valid_slot' => [
        'title' => 'Valid slot',
        'description' => 'Valid slot description',
        ],
        'invalid_slot' => [
        'title' => [
        'hello' => 'Invalid slot',
        'world' => 'Invalid slot',
        ],
        'description' => 'Title must be string',
        ],
        ];
        yield 'invalid slot (type)' => [$cta_with_invalid_slot_type];
        }
        /**
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Finish editing this message first!
        Please register or to comment