Issue #3442833 by binoli lalani, vivek panicker, pradhumanjain2311, longwave,...

Issue #3442833 by binoli lalani, vivek panicker, pradhumanjain2311, longwave, prudloff, smustgrave, alexpott: Undefined array key warning in UrlHelper::parse()

core/lib/Drupal/Component/Utility/UrlHelper.php

@@ -193,9 +193,10 @@ public static function parse($url) {
     // appears in front of the '?' query argument delimiter.
     $scheme_delimiter_position = strpos($url, '://');
     $query_delimiter_position = strpos($url, '?');
-    if ($scheme_delimiter_position !== FALSE && ($query_delimiter_position === FALSE || $scheme_delimiter_position < $query_delimiter_position)) {
+    $fragment_delimiter_position = strpos($url, '#');
+    if ($scheme_delimiter_position !== FALSE && ($query_delimiter_position === FALSE || $scheme_delimiter_position < $query_delimiter_position) && ($fragment_delimiter_position === FALSE || $scheme_delimiter_position < $fragment_delimiter_position)) {
       // Split off the fragment, if any.
-      if (str_contains($url, '#')) {
+      if ($fragment_delimiter_position !== FALSE) {
         [$url, $options['fragment']] = explode('#', $url, 2);
       }
 

core/tests/Drupal/Tests/Component/Utility/UrlHelperTest.php

@@ -386,6 +386,14 @@ public static function providerTestParse() {
           'fragment' => 'footer',
         ],
       ],
+      'Malformed URL should not trigger PHP warnings' => [
+        "#/://#",
+        [
+          'path' => NULL,
+          'query' => [],
+          'fragment' => "/://#",
+        ],
+      ],
     ];
   }