Unverified Commit 926b4849 authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #3238860 by mstrelan, Theresa.Grannum, hooroomoo, bnjmnm, larowlan:... 

Issue #3238860 by mstrelan, Theresa.Grannum, hooroomoo, bnjmnm, larowlan: Refactor (if feasible) use of jquery map to use vanillaJS
parent 36f09c06

core/.eslintrc.jquery.json

+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ 
    "jquery/no-is-function": 2,

    "jquery/no-is": 0,

    "jquery/no-load": 2,

    "jquery/no-map": 0,

    "jquery/no-map": 2,

    "jquery/no-merge": 2,

    "jquery/no-param": 2,

    "jquery/no-parent": 0,

core/misc/form.es6.js

+3 −9
Original line number Diff line number Diff line
@@ -157,15 +157,9 @@ 
   *   Array of IDs for form fields.

   */

  function fieldsList(form) {

    const $fieldList = $(form)

      .find('[name]')

      .map(

    // We use id to avoid name duplicates on radio fields and filter out

    // elements with a name but no id.

        (index, element) => element.getAttribute('id'),

      );

    // Return a true array.

    return $.makeArray($fieldList);

    return [].map.call(form.querySelectorAll('[name][id]'), (el) => el.id);

  }



  /**

core/misc/form.js

+2 −3
Original line number Diff line number Diff line
@@ -50,10 +50,9 @@ 
  }



  function fieldsList(form) {

    var $fieldList = $(form).find('[name]').map(function (index, element) {

      return element.getAttribute('id');

    return [].map.call(form.querySelectorAll('[name][id]'), function (el) {

      return el.id;

    });

    return $.makeArray($fieldList);

  }



  Drupal.behaviors.formUpdated = {