Commit 8e8418bc authored by catch's avatar catch
Browse files

task: #3563359 Explore why PHP 8.4 polyfill is not loaded for test runs on PHP 8.3 

By: nicxvan
By: mondrake
By: mstrelan
By: smustgrave
(cherry picked from commit 26873db1)
parent fc8c9c11

core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php

+1 −2
Changes for core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php: 1 added line, 2 removed lines.
Original line number Diff line number Diff line
@@ -1394,8 +1394,7 @@ private function loadSingleCardinalityFields( 


        // If all the field values are null, then there was no result for this

        // field.

        // @todo use array_any() once Drupal core requires PHP 8.4.

        if (empty(array_filter($field_values, $is_not_null))) {

        if (!array_any($field_values, $is_not_null)) {

          continue;

        }

        if (!isset($values[$value_key][$field_name][$langcode])) {

core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php

+4 −4
Changes for core/modules/package_manager/tests/src/Build/TemplateProjectTestBase.php: 4 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -441,12 +441,12 @@ protected function createVendorRepository(array $versions = []): void { 
      $name = $package_info['name'];



      $requirements = $package_info['require'] ?? [];

      // These polyfills are dependencies of some packages, but for reasons we

      // don't understand, they are not installed in code bases built on PHP

      // versions that are newer than the ones being polyfilled, which means we

      // These polyfills are dependencies of some packages, but because they

      // appear in the "replace" section of our composer.json file, we

      // won't be able to build our test project because these polyfills aren't

      // available in the local code base. Since we're guaranteed to be on PHP

      // 8.5 or later, no package should need to polyfill older versions.

      // 8.5 or later, no package should need to polyfill older versions. This

      // list should be kept in sync with the replace section of composer.json.

      unset(

        $requirements['symfony/polyfill-php72'],

        $requirements['symfony/polyfill-php73'],