Verified Commit 8dd90d73 authored by Dave Long's avatar Dave Long
Browse files

Issue #3421626 by phenaproxima, Wim Leers, borisson_: Mark config schema types... 

Issue #3421626 by phenaproxima, Wim Leers, borisson_: Mark config schema types (field.field_settings.* and field.storage_settings.*)) for field types that have no settings as fully validatable

(cherry picked from commit 7e2b0d45)
parent 277cf4a8

core/config/schema/core.data_types.schema.yml

+32 −42
Original line number Diff line number Diff line
@@ -616,17 +616,34 @@ core_date_format_pattern.1: 
field.storage_settings.*:

  type: mapping

  label: 'Settings'

  # By default, a field type has no settings, so this can safely be considered

  # fully validatable. A `FOO` field type that has one or more settings is

  # required to create a `field.storage_settings.FOO` config schema type, and

  # cannot possibly forget to do that, because validation errors would be

  # triggered if it ever tried to save a setting, since this mapping allows no

  # key-value pairs at all.

  constraints:

    FullyValidatable: ~



field.field_settings.*:

  type: mapping

  label: 'Settings'

  # By default, a field type has no settings, so this can safely be considered

  # fully validatable. A `FOO` field type that has one or more settings is

  # required to create a `field.field_settings.FOO` config schema type, and

  # cannot possibly forget to do that, because validation errors would be

  # triggered if it ever tried to save a setting, since this mapping allows no

  # key-value pairs at all.

  constraints:

    FullyValidatable: ~



field.value.*:

  type: mapping

  label: 'Default value'



# Schema for the configuration of the String field type.



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.string:

  type: mapping

  label: 'String settings'
@@ -641,10 +658,6 @@ field.storage_settings.string: 
      type: boolean

      label: 'Contains US ASCII characters only'



field.field_settings.string:

  type: mapping

  label: 'String settings'



field.value.string:

  type: mapping

  label: 'Default value'
@@ -663,10 +676,6 @@ field.storage_settings.string_long: 
      type: boolean

      label: 'Case sensitive'



field.field_settings.string_long:

  type: mapping

  label: 'String (long) settings'



field.value.string_long:

  type: mapping

  label: 'Default value'
@@ -676,17 +685,15 @@ field.value.string_long: 
      label: 'Value'



# Schema for the configuration of the Password field type.



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.password:

  type: field.storage_settings.string

  label: 'Password settings'



field.field_settings.password:

  type: mapping

  label: 'Password settings'



# Schema for the configuration of the URI field type.



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.uri:

  type: field.storage_settings.string

  label: 'URI settings'
@@ -698,10 +705,6 @@ field.storage_settings.uri: 
      type: boolean

      label: 'Case sensitive'



field.field_settings.uri:

  type: mapping

  label: 'URI settings'



field.value.uri:

  type: mapping

  label: 'Default value'
@@ -711,15 +714,10 @@ field.value.uri: 
      label: 'Value'



# Schema for the configuration of the Created field type.



field.storage_settings.created:

  type: mapping

  label: 'Created timestamp settings'



field.field_settings.created:

  type: mapping

  label: 'Created timestamp settings'



# This field type has no field storage settings, so no specific config schema type.

# @see `type: field.storage_settings.*`

# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.value.created:

  type: mapping

  label: 'Default value'
@@ -729,15 +727,10 @@ field.value.created: 
      label: 'Value'



# Schema for the configuration of the Changed field type.



field.storage_settings.changed:

  type: mapping

  label: 'Changed timestamp settings'



field.field_settings.changed:

  type: mapping

  label: 'Changed timestamp settings'



# This field type has no field storage settings, so no specific config schema type.

# @see `type: field.storage_settings.*`

# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.value.changed:

  type: mapping

  label: 'Default value'
@@ -805,11 +798,8 @@ field.value.boolean: 
      label: 'Value'



# Schema for the configuration of the Email field type.



field.storage_settings.email:

  type: mapping

  label: 'Email settings'



# This field type has no field storage settings, so no specific config schema type.

# @see `type: field.storage_settings.*`

field.field_settings.email:

  type: mapping

  label: 'Email settings'

core/modules/datetime/config/schema/datetime.schema.yml

+2 −4
Original line number Diff line number Diff line 
# Schema for the configuration files of the Datetime module.



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.datetime:

  type: mapping

  label: 'Datetime settings'
@@ -8,10 +10,6 @@ field.storage_settings.datetime: 
      type: string

      label: 'Date type'



field.field_settings.datetime:

  type: mapping

  label: 'Datetime settings'



field.value.datetime:

  type: mapping

  label: 'Default value'

core/modules/datetime_range/config/schema/datetime_range.schema.yml

+2 −5
Original line number Diff line number Diff line 
# Schema for the configuration files of the Datetime Range module.



# Daterange field type.



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.daterange:

  type: field.storage_settings.datetime

  label: 'Date range settings'



field.field_settings.daterange:

  type: field.field_settings.datetime

  label: 'Date range settings'



field.value.daterange:

  type: mapping

  label: 'Default value'

core/modules/link/config/schema/link.schema.yml

+2 −4
Original line number Diff line number Diff line
@@ -35,10 +35,8 @@ field.widget.settings.link_default: 
      type: label

      label: 'Placeholder for link text'



field.storage_settings.link:

  type: mapping

  label: 'Link settings'



# This field type has no field storage settings, so no specific config schema type.

# @see `type: field.storage_settings.*`

field.field_settings.link:

  type: mapping

  label: 'Link settings'

core/modules/options/config/schema/options.schema.yml

+6 −12
Original line number Diff line number Diff line 
# Schema for the configuration files of the Options module.



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.list_integer:

  type: mapping

  label: 'List (integer) settings'
@@ -21,10 +23,6 @@ field.storage_settings.list_integer: 
      type: string

      label: 'Allowed values function'



field.field_settings.list_integer:

  label: 'List (integer) settings'

  type: mapping



field.value.list_integer:

  type: mapping

  label: 'Default value'
@@ -33,6 +31,8 @@ field.value.list_integer: 
      type: integer

      label: 'Value'



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.list_float:

  type: mapping

  label: 'List (float) settings'
@@ -54,10 +54,6 @@ field.storage_settings.list_float: 
      type: string

      label: 'Allowed values function'



field.field_settings.list_float:

  label: 'List (float) settings'

  type: mapping



field.value.list_float:

  type: mapping

  label: 'Default value'
@@ -66,6 +62,8 @@ field.value.list_float: 
      type: string

      label: 'Value'



# This field type has no field instance settings, so no specific config schema type.

# @see `type: field.field_settings.*`

field.storage_settings.list_string:

  type: mapping

  label: 'List (text) settings'
@@ -87,10 +85,6 @@ field.storage_settings.list_string: 
      type: string

      label: 'Allowed values function'



field.field_settings.list_string:

  label: 'List (text) settings'

  type: mapping



field.value.list_string:

  type: mapping

  label: 'Default value'