Commit 85b55e17 authored by catch's avatar catch
Browse files

Issue #3371992 by andypost, daffie: Tests should check sqlite version using PDO_sqlite extension

(cherry picked from commit 126395fe)
parent f0f1da16
Loading
Loading
Loading
Loading
+2 −1
Original line number Diff line number Diff line
@@ -16,7 +16,8 @@ class HtRouterTest extends QuickStartTestBase {
   * @covers ::instantiateServer
   */
  public function testHtRouter() {
    if (version_compare(\SQLite3::version()['versionString'], Tasks::SQLITE_MINIMUM_VERSION) < 0) {
    $sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];
    if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {
      $this->markTestSkipped();
    }

+2 −1
Original line number Diff line number Diff line
@@ -28,7 +28,8 @@ class GenerateThemeTest extends QuickStartTestBase {
   * {@inheritdoc}
   */
  protected function setUp(): void {
    if (version_compare(\SQLite3::version()['versionString'], Tasks::SQLITE_MINIMUM_VERSION) < 0) {
    $sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];
    if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {
      $this->markTestSkipped();
    }
    parent::setUp();
+4 −2
Original line number Diff line number Diff line
@@ -85,7 +85,8 @@ protected function tearDown(): void {
   * Tests the quick-start command.
   */
  public function testQuickStartCommand() {
    if (version_compare(\SQLite3::version()['versionString'], Tasks::SQLITE_MINIMUM_VERSION) < 0) {
    $sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];
    if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {
      $this->markTestSkipped();
    }

@@ -140,7 +141,8 @@ public function testQuickStartCommand() {
   * Tests the quick-start commands.
   */
  public function testQuickStartInstallAndServerCommands() {
    if (version_compare(\SQLite3::version()['versionString'], Tasks::SQLITE_MINIMUM_VERSION) < 0) {
    $sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];
    if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {
      $this->markTestSkipped();
    }