Skip to content
Snippets Groups Projects
Verified Commit 84198074 authored by Dave Long's avatar Dave Long
Browse files

Issue #3343913 by _shY, smustgrave, catch, xjm, quietone: Add comments...

Issue #3343913 by _shY, smustgrave, catch, xjm, quietone: Add comments explaining performance improvement in TypedData

(cherry picked from commit efecede1)
parent b99e5644
No related branches found
No related tags found
5 merge requests!11628Update file MediaLibraryWidget.php,!7564Revert "Issue #3364773 by roshnichordiya, Chris Matthews, thakurnishant_06,...,!5752Issue #3275828 by joachim, quietone, bradjones1, Berdir: document the reason...,!5627Issue #3261805: Field not saved when change of 0 on string start,!3106Issue #3017548: "Filtered HTML" text format does not support manual teaser break (<!--break-->)
Pipeline #58752 failed
Pipeline: drupal

#58756

    Pipeline: drupal

    #58755

      Pipeline: drupal

      #58754

        +1
        ...@@ -175,6 +175,10 @@ public function getPropertyPath() { ...@@ -175,6 +175,10 @@ public function getPropertyPath() {
        // The property path of this data object is the parent's path appended // The property path of this data object is the parent's path appended
        // by this object's name. // by this object's name.
        $prefix = $this->parent->getPropertyPath(); $prefix = $this->parent->getPropertyPath();
        // Variables in double quotes used to leverage fast string concatenation.
        // In PHP 7+ concatenation with variable inside string is the fastest.
        // @see https://blog.blackfire.io/php-7-performance-improvements-encapsed-strings-optimization.html
        // This is being done because the code can run in the critical path.
        return $prefix !== '' ? "{$prefix}.{$this->name}" : $this->name; return $prefix !== '' ? "{$prefix}.{$this->name}" : $this->name;
        } }
        // If no parent is set, this is the root of the data tree. Thus the property // If no parent is set, this is the root of the data tree. Thus the property
        ......
        0% Loading or .
        You are about to add 0 people to the discussion. Proceed with caution.
        Finish editing this message first!
        Please register or to comment