Unverified Commit 7e844b90 authored by Alex Pott's avatar Alex Pott
Browse files

Issue #3018148 by Lendude, tstoeckler: Views bulk forms perform redirects to... 

Issue #3018148 by Lendude, tstoeckler: Views bulk forms perform redirects to the confirmation page even if it is not allowed for the user

(cherry picked from commit 78f8ee05)
parent 5541aeb8

core/modules/node/tests/src/Functional/Views/BulkFormAccessTest.php

+16 −0
Original line number Diff line number Diff line
@@ -128,6 +128,22 @@ public function testNodeEditAccess() { 
    // Re-load the node and check the status.

    $node = Node::load($node->id());

    $this->assertTrue($node->isPublished(), 'The node is still published.');



    // Try to delete the node and check that we are not redirected to the

    // conformation form but stay on the content view.

    $this->assertNotEmpty($this->cssSelect('#views-form-test-node-bulk-form-page-1'));

    $edit = [

      'node_bulk_form[0]' => TRUE,

      'action' => 'node_delete_action',

    ];

    $this->drupalPostForm('test-node-bulk-form', $edit, t('Apply to selected items'));

    // Test that the action message isn't shown.

    $this->assertRaw(new FormattableMarkup('No access to execute %action on the @entity_type_label %entity_label.', [

      '%action' => 'Delete content',

      '@entity_type_label' => 'Content',

      '%entity_label' => $node->label(),

    ]));

    $this->assertNotEmpty($this->cssSelect('#views-form-test-node-bulk-form-page-1'));

  }



  /**

core/modules/views/src/Plugin/views/field/BulkForm.php

+9 −5
Original line number Diff line number Diff line
@@ -422,6 +422,12 @@ public function viewsFormSubmit(&$form, FormStateInterface $form_state) { 
        $entities[$bulk_form_key] = $entity;

      }



      // If there were entities selected but the action isn't allowed on any of

      // them, we don't need to do anything further.

      if (!$count) {

        return;

      }



      $action->execute($entities);



      $operation_definition = $action->getPluginDefinition();
@@ -434,14 +440,12 @@ public function viewsFormSubmit(&$form, FormStateInterface $form_state) { 
      else {

        // Don't display the message unless there are some elements affected and

        // there is no confirmation form.

        if ($count) {

        $this->messenger->addStatus($this->formatPlural($count, '%action was applied to @count item.', '%action was applied to @count items.', [

          '%action' => $action->label(),

        ]));

      }

    }

  }

  }



  /**

   * Returns the message to be displayed when there are no selected items.