Verified Commit 7cf46468 authored by Théodore Biadala's avatar Théodore Biadala
Browse files

Issue #3521953 by tom konda, smustgrave, quietone: Existence check for... 

Issue #3521953 by tom konda, smustgrave, quietone: Existence check for JavaScript object and it's property across multi-lines can replace with optional chaining
parent 5aa1596b

core/misc/tabledrag.js

+2 −4
Original line number Diff line number Diff line
@@ -1064,8 +1064,7 @@ 
      const nextRow = $nextRow.get(0);

      sourceRow = changedRow;

      if (

        previousRow &&

        previousRow.matches('.draggable') &&

        previousRow?.matches('.draggable') &&

        $previousRow.find(`.${group}`).length

      ) {

        if (this.indentEnabled) {
@@ -1079,8 +1078,7 @@ 
          sourceRow = previousRow;

        }

      } else if (

        nextRow &&

        nextRow.matches('.draggable') &&

        nextRow?.matches('.draggable') &&

        $nextRow.find(`.${group}`).length

      ) {

        if (this.indentEnabled) {

core/modules/big_pipe/js/big_pipe.js

+1 −2
Original line number Diff line number Diff line
@@ -91,8 +91,7 @@ 
    return Boolean(

      node.nodeType === Node.ELEMENT_NODE &&

        node.nodeName === 'SCRIPT' &&

        node.dataset &&

        node.dataset.bigPipeReplacementForPlaceholderWithId &&

        node.dataset?.bigPipeReplacementForPlaceholderWithId &&

        typeof drupalSettings.bigPipePlaceholderIds[

          node.dataset.bigPipeReplacementForPlaceholderWithId

        ] !== 'undefined',

core/modules/ckeditor5/js/build/drupalMedia.js

+1 −1

File changed.

Preview size limit exceeded, changes collapsed.

core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupallinkmedia/drupallinkmediaui.js

+1 −2
Original line number Diff line number Diff line
@@ -103,8 +103,7 @@ export default class DrupalLinkMediaUI extends Plugin { 
  _isSelectedLinkedMedia(selection) {

    const selectedModelElement = selection.getSelectedElement();

    return (

      !!selectedModelElement &&

      selectedModelElement.is('element', 'drupalMedia') &&

      selectedModelElement?.is('element', 'drupalMedia') &&

      selectedModelElement.hasAttribute('linkHref')

    );

  }

core/modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/mediaimagetextalternative/mediaimagetextalternativecommand.js

+1 −2
Original line number Diff line number Diff line
@@ -22,8 +22,7 @@ export default class MediaImageTextAlternativeCommand extends Command { 
      this.editor.model.document.selection,

    );

    this.isEnabled =

      !!drupalMediaElement &&

      drupalMediaElement.getAttribute('drupalMediaIsImage') &&

      drupalMediaElement?.getAttribute('drupalMediaIsImage') &&

      drupalMediaElement.getAttribute('drupalMediaIsImage') !== METADATA_ERROR;



    if (this.isEnabled) {