Verified Commit 7c75b993 authored by Dave Long's avatar Dave Long
Browse files

refactor: #3608912 Move search updates back to search module and fix missing plugin errors 

By: catch
By: godotislate
By: nicxvan
By: longwave
(cherry picked from commit af7dd6ef)
parent 06b8d836

core/.phpstan-baseline.php

+72 −0
Original line number Diff line number Diff line
@@ -16077,6 +16077,24 @@ 
	'count' => 1,

	'path' => __DIR__ . '/modules/help/src/HelpTopicTwigLoader.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\help\\\\Plugin\\\\Search\\\\HelpSearch\\:\\:indexClear\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/help/src/Plugin/Search/HelpSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\help\\\\Plugin\\\\Search\\\\HelpSearch\\:\\:markForReindex\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/help/src/Plugin/Search/HelpSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\help\\\\Plugin\\\\Search\\\\HelpSearch\\:\\:updateIndex\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/help/src/Plugin/Search/HelpSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\Tests\\\\help\\\\Kernel\\\\HelpTopicTest\\:\\:assertBreadcrumb\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',
@@ -23129,6 +23147,36 @@ 
	'count' => 1,

	'path' => __DIR__ . '/modules/node/src/NodeViewBuilder.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:\\:indexClear\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/node/src/Plugin/Search/NodeSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:\\:indexStatus\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/node/src/Plugin/Search/NodeSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:\\:markForReindex\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/node/src/Plugin/Search/NodeSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:\\:submitConfigurationForm\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/node/src/Plugin/Search/NodeSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:\\:updateIndex\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/modules/node/src/Plugin/Search/NodeSearch.php',

];

$ignoreErrors[] = [

	'message' => '#^Call to method __construct\\(\\) of deprecated class Drupal\\\\migrate_drupal\\\\Plugin\\\\migrate\\\\source\\\\DrupalSqlBase\\:

in drupal\\:11\\.3\\.0 and is removed from drupal\\:12\\.0\\.0\\. There is no
@@ -25205,6 +25253,30 @@ 
	'count' => 1,

	'path' => __DIR__ . '/modules/search/tests/src/Functional/SearchCommentTest.php',

];

$ignoreErrors[] = [

	'message' => '#^Call to method execute\\(\\) of deprecated class Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:

in drupal\\:11\\.4\\.0 and is removed from drupal\\:12\\.0\\.0\\. Instead, use

  \\\\Drupal\\\\search_node\\\\Plugin\\\\Search\\\\SearchNode\\.$#',

	'identifier' => 'method.deprecatedClass',

	'count' => 4,

	'path' => __DIR__ . '/modules/search/tests/src/Functional/SearchMultilingualEntityTest.php',

];

$ignoreErrors[] = [

	'message' => '#^Call to method indexStatus\\(\\) of deprecated class Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:

in drupal\\:11\\.4\\.0 and is removed from drupal\\:12\\.0\\.0\\. Instead, use

  \\\\Drupal\\\\search_node\\\\Plugin\\\\Search\\\\SearchNode\\.$#',

	'identifier' => 'method.deprecatedClass',

	'count' => 1,

	'path' => __DIR__ . '/modules/search/tests/src/Functional/SearchMultilingualEntityTest.php',

];

$ignoreErrors[] = [

	'message' => '#^Call to method updateIndex\\(\\) of deprecated class Drupal\\\\node\\\\Plugin\\\\Search\\\\NodeSearch\\:

in drupal\\:11\\.4\\.0 and is removed from drupal\\:12\\.0\\.0\\. Instead, use

  \\\\Drupal\\\\search_node\\\\Plugin\\\\Search\\\\SearchNode\\.$#',

	'identifier' => 'method.deprecatedClass',

	'count' => 1,

	'path' => __DIR__ . '/modules/search/tests/src/Functional/SearchMultilingualEntityTest.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\Tests\\\\search\\\\Functional\\\\SearchNumberMatchingTest\\:\\:cronRun\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

core/modules/block/tests/src/Functional/BlockWeightUpdateTest.php

+2 −0
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
use Drupal\FunctionalTests\Update\UpdatePathTestBase;

use PHPUnit\Framework\Attributes\CoversFunction;

use PHPUnit\Framework\Attributes\Group;

use PHPUnit\Framework\Attributes\IgnoreDeprecations;

use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;



/**
@@ -16,6 +17,7 @@ 
#[Group('block')]

#[CoversFunction('block_post_update_make_weight_integer')]

#[RunTestsInSeparateProcesses]

#[IgnoreDeprecations]

class BlockWeightUpdateTest extends UpdatePathTestBase {



  /**

core/modules/block/tests/src/Functional/Update/MenuBlockDepthTest.php

+2 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
use Drupal\block\Entity\Block;

use Drupal\FunctionalTests\Update\UpdatePathTestBase;

use PHPUnit\Framework\Attributes\Group;

use PHPUnit\Framework\Attributes\IgnoreDeprecations;

use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;



/**
@@ -14,6 +15,7 @@ 
 */

#[Group('system')]

#[RunTestsInSeparateProcesses]

#[IgnoreDeprecations]

final class MenuBlockDepthTest extends UpdatePathTestBase {



  /**

core/modules/block_content/tests/src/Functional/Update/BlockContentRemoveListingEmptyUpdateTest.php

+2 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
use Drupal\FunctionalTests\Update\UpdatePathTestBase;

use Drupal\views\Entity\View;

use PHPUnit\Framework\Attributes\Group;

use PHPUnit\Framework\Attributes\IgnoreDeprecations;

use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;



/**
@@ -16,6 +17,7 @@ 
 */

#[Group('Update')]

#[RunTestsInSeparateProcesses]

#[IgnoreDeprecations]

class BlockContentRemoveListingEmptyUpdateTest extends UpdatePathTestBase {



  /**

core/modules/block_content/tests/src/Functional/Update/BlockContentStatusInfoUpdatePathTest.php

+2 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 
use Drupal\block\Entity\Block;

use Drupal\FunctionalTests\Update\UpdatePathTestBase;

use PHPUnit\Framework\Attributes\Group;

use PHPUnit\Framework\Attributes\IgnoreDeprecations;

use PHPUnit\Framework\Attributes\RunTestsInSeparateProcesses;



// cspell:ignore anotherblock
@@ -15,6 +16,7 @@ 
 */

#[Group('block_content')]

#[RunTestsInSeparateProcesses]

#[IgnoreDeprecations]

class BlockContentStatusInfoUpdatePathTest extends UpdatePathTestBase {



  /**