Verified Commit 7a4b1cb6 authored by Dave Long's avatar Dave Long
Browse files

task: #3515403 Update to selenium/standalone-chrome:133 

By: mstrelan
By: quietone
By: longwave
parent daaad28a

.gitlab-ci/pipeline.yml

+1 −1
Changes for .gitlab-ci/pipeline.yml: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ variables: 
    - "--allowed-origins=*"



.with-selenium-chrome: &with-selenium-chrome

  name: selenium/standalone-chrome:127.0

  name: selenium/standalone-chrome:133.0

  alias: selenium

  variables:

    JAVA_OPTS: $SELENIUM_JAVA_OPTS

core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5AllowedTagsTest.php

+1 −0
Changes for core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5AllowedTagsTest.php: 1 added line, 0 removed lines.
Original line number Diff line number Diff line
@@ -475,6 +475,7 @@ public function testFullHtml(): void { 
    $this->drupalGet('node/1/edit');

    $page->pressButton('Save');



    $this->assertTrue($assert_session->waitForText('NASA is an acronym.'));

    $assert_session->responseContains('<p><a foo="bar" hreflang="en" href="https://example.com"><abbr title="National Aeronautics and Space Administration">NASA</abbr> is an acronym.</a></p>');



    // Configure Basic HTML text format to use CKE5 and enable the link plugin.

core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.php

+3 −3
Changes for core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5Test.php: 3 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -235,7 +235,7 @@ public function languageOfPartsPluginConfigureLanguageListHelper($page, $assert_ 
      $assert_session->assertWaitOnAjaxRequest();

    }

    $page->pressButton('Save configuration');

    $assert_session->responseContains('The text format <em class="placeholder">ckeditor5</em> has been updated.');

    $this->assertNotEmpty($assert_session->waitForText('The text format ckeditor5 has been updated.'));

  }



  /**
@@ -804,7 +804,7 @@ function (ConstraintViolationInterface $v) { 
    $editor = $page->find('css', '.ck-content');

    $editor->setValue('Very important information');

    $page->pressButton('Save');

    $this->assertSession()->responseContains('Very important information');

    $this->assertTrue($this->assertSession()->waitForText('Very important information'));



    // Test that changes only in source are saved.

    $this->drupalGet('node/1/edit');
@@ -814,7 +814,7 @@ function (ConstraintViolationInterface $v) { 
    $editor = $page->find('css', '.ck-source-editing-area textarea');

    $editor->setValue('Text hidden in the source');

    $page->pressButton('Save');

    $this->assertSession()->responseContains('Text hidden in the source');

    $this->assertTrue($this->assertSession()->waitForText('Text hidden in the source'));

  }



}

core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php

+1 −2
Changes for core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php: 1 added line, 2 removed lines.
Original line number Diff line number Diff line
@@ -54,8 +54,7 @@ public function testAltTextRequired(bool $unrestricted): void { 


    // Add alt text to the block image.

    $image_block->find('css', '.image-alternative-text-missing button')->click();

    $this->assertNotEmpty($assert_session->waitForElementVisible('css', '.ck-balloon-panel'));

    $this->assertVisibleBalloon('.ck-text-alternative-form');

    $this->assertNotEmpty($assert_session->waitForElementVisible('css', '.ck-balloon-panel .ck-text-alternative-form'));



    // Ensure that the missing alt text warning is hidden when the alternative

    // text form is open.

core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderDisableInteractionsTest.php

+1 −1
Changes for core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderDisableInteractionsTest.php: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ public function testFormsLinksDisabled(): void { 
    // Resize window due to bug in Chromedriver when clicking on overlays over

    // iFrames.

    // @see https://bugs.chromium.org/p/chromedriver/issues/detail?id=2758

    $this->getSession()->resizeWindow(1200, 1200);

    $this->getSession()->resizeWindow(1200, 1339);

    $assert_session = $this->assertSession();

    $page = $this->getSession()->getPage();