Issue #3494678 by mstrelan, nicxvan: Add void return type to all procedural... (75edbfda) · Commits · project / drupal

core/.phpstan-baseline.php

+0 −222

Original line number	Diff line number	Diff line
		@@ -12598,12 +12598,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/ckeditor5/ckeditor5.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function ckeditor5_module_implements_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/ckeditor5/ckeditor5.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\ckeditor5\\\\Annotation\\\\CKEditor5Plugin\\:\\:setClass\$\$ has no return type specified\\.$#',
		@@ -16552,12 +16546,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/content_translation/content_translation.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function content_translation_module_implements_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/content_translation/content_translation.module',
		];
		$ignoreErrors[] = [
		// identifier: variable.undefined
		'message' => '#^Variable \\$locked_languages might not be defined\\.$#',
		@@ -23662,12 +23650,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/language/tests/src/Unit/Menu/LanguageLocalTasksTest.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function layout_builder_module_implements_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/layout_builder/layout_builder.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\layout_builder_expose_all_field_blocks\\\\Hook\\\\LayoutBuilderExposeAllFieldBlocksHooks\\:\\:help\$\$ has no return type specified\\.$#',
		@@ -24286,12 +24268,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/layout_builder/tests/modules/layout_builder_form_block_test/src/Plugin/Block/TestFormApiFormBlock.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function layout_builder_test_module_implements_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/layout_builder/tests/modules/layout_builder_test/layout_builder_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function layout_builder_test_node_view\$\$ has no return type specified\\.$#',
		@@ -27118,12 +27094,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/media_library/src/Routing/RouteSubscriber.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function media_library_form_overwrite_test_media_source_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/media_library/tests/modules/media_library_form_overwrite_test/media_library_form_overwrite_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\media_library_test\\\\Form\\\\TestNodeFormOverride\\:\\:submitForm\$\$ has no return type specified\\.$#',
		@@ -29976,12 +29946,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/navigation/navigation.install',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function navigation_module_implements_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/navigation/navigation.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function navigation_post_update_set_logo_dimensions_default\$\$ has no return type specified\\.$#',
		@@ -36144,24 +36108,12 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/cache_test/src/Controller/CacheTestController.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function common_test_module_implements_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/common_test/common_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function common_test_preprocess\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/common_test/common_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function olivero_drupal_alter_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/common_test/common_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\common_test\\\\Controller\\\\CommonTestController\\:\\:typeLinkActiveClass\$\$ has no return type specified\\.$#',
		@@ -36282,12 +36234,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/delay_cache_tags_invalidation/src/Hook/DelayCacheTagsInvalidationHooks.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function deprecation_test_deprecated_alter_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/deprecation_test/deprecation_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function deprecation_test_deprecated_hook\$\$ has no return type specified\\.$#',
		@@ -38767,12 +38713,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/module_test/module_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function module_test_module_implements_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/module_test/module_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function module_test_modules_installed\$\$ has no return type specified\\.$#',
		@@ -38785,12 +38725,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/module_test/module_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function module_test_system_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/module_test/module_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function module_test_post_update_test\$\$ has no return type specified\\.$#',
		@@ -39741,12 +39675,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/twig_theme_test/twig_theme_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function unversioned_assets_test_library_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/modules/unversioned_assets_test/unversioned_assets_test.module',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\update_script_test\\\\Controller\\\\UpdateScriptTestController\\:\\:databaseUpdatesMenuItem\$\$ has no return type specified\\.$#',
		@@ -41655,48 +41583,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_subtheme/test_subtheme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_element_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_theme/test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_library_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_theme/test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_theme_registry_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_theme/test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_theme_suggestions_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_theme/test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_theme_suggestions_node_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_theme/test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_theme_suggestions_theme_test_suggestions_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_theme/test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_theme_test_alter_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/system/tests/themes/test_theme/test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function test_theme_depending_on_modules_post_update_module_install\$\$ has no return type specified\\.$#',
		@@ -53703,18 +53589,6 @@
		'count' => 1,
		'path' => __DIR__ . '/modules/views_ui/tests/src/FunctionalJavascript/PreviewTest.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function views_ui_test_theme_views_ui_display_tab_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/views_ui/tests/themes/views_ui_test_theme/views_ui_test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function views_ui_test_theme_views_ui_display_top_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/modules/views_ui/tests/themes/views_ui_test_theme/views_ui_test_theme.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function views_ui_contextual_links_suppress\$\$ has no return type specified\\.$#',
		@@ -55719,12 +55593,6 @@
		'count' => 1,
		'path' => __DIR__ . '/profiles/demo_umami/tests/src/Functional/DemoUmamiProfileTest.php',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function umami_theme_suggestions_block_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/profiles/demo_umami/themes/umami/umami.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\Tests\\\\minimal\\\\Functional\\\\MinimalTest\\:\\:assertConfigSchema\$\$ has no return type specified\\.$#',
		@@ -62588,72 +62456,12 @@
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_element_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_page_attachments_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_system_module_invoked_library_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_system_module_invoked_theme_registry_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_theme_registry_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_theme_suggestions_details_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_theme_suggestions_form_element_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_theme_suggestions_maintenance_page_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_views_pre_render\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_views_ui_display_tab_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function claro_views_ui_display_top_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/claro/claro.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\claro\\\\ClaroPreRender\\:\\:managedFile\$\$ has no return type specified\\.$#',
		@@ -62690,36 +62498,6 @@
		'count' => 1,
		'path' => __DIR__ . '/themes/engines/twig/twig.engine',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function olivero_element_info_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/olivero/olivero.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function olivero_theme_suggestions_block_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/olivero/olivero.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function olivero_theme_suggestions_form_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/olivero/olivero.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function olivero_theme_suggestions_menu_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/olivero/olivero.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Function olivero_theme_suggestions_user_alter\$\$ has no return type specified\\.$#',
		'count' => 1,
		'path' => __DIR__ . '/themes/olivero/olivero.theme',
		];
		$ignoreErrors[] = [
		// identifier: missingType.return
		'message' => '#^Method Drupal\\\\olivero\\\\OliveroPreRender\\:\\:textFormat\$\$ has no return type specified\\.$#',

core/modules/ckeditor5/ckeditor5.module

+1 −1

Original line number	Diff line number	Diff line
		@@ -20,7 +20,7 @@
		/**
		* Implements hook_module_implements_alter().
		*/
		function ckeditor5_module_implements_alter(&$implementations, $hook) {
		function ckeditor5_module_implements_alter(&$implementations, $hook): void {
		// This module's implementation of form_filter_format_form_alter() must happen
		// after the editor module's implementation, as that implementation adds the
		// active editor to $form_state. It must also happen after the media module's

core/modules/content_translation/content_translation.module

+1 −1

Original line number	Diff line number	Diff line
		@@ -13,7 +13,7 @@
		/**
		* Implements hook_module_implements_alter().
		*/
		function content_translation_module_implements_alter(&$implementations, $hook) {
		function content_translation_module_implements_alter(&$implementations, $hook): void {
		switch ($hook) {
		// Move our hook_entity_type_alter() implementation to the end of the list.
		case 'entity_type_alter':

core/modules/layout_builder/layout_builder.module

+1 −1

Original line number	Diff line number	Diff line
		@@ -9,7 +9,7 @@
		/**
		* Implements hook_module_implements_alter().
		*/
		function layout_builder_module_implements_alter(&$implementations, $hook) {
		function layout_builder_module_implements_alter(&$implementations, $hook): void {
		if ($hook === 'entity_view_alter') {
		// Ensure that this module's implementation of hook_entity_view_alter() runs
		// last so that other modules that use this hook to render extra fields will

core/modules/layout_builder/tests/modules/layout_builder_test/layout_builder_test.module

+1 −1

Original line number	Diff line number	Diff line
		@@ -53,7 +53,7 @@ function layout_builder_test_preprocess_layout__twocol_section(&$vars): void {
		/**
		* Implements hook_module_implements_alter().
		*/
		function layout_builder_test_module_implements_alter(&$implementations, $hook) {
		function layout_builder_test_module_implements_alter(&$implementations, $hook): void {
		if ($hook === 'system_breadcrumb_alter') {
		// Move our hook_system_breadcrumb_alter() implementation to run before
		// layout_builder_system_breadcrumb_alter().