Skip to content
Snippets Groups Projects
Unverified Commit 753eef8a authored by Lauri Timmanee's avatar Lauri Timmanee
Browse files

Issue #2978498 by Cottser, Kingdutch: Using the module filter on the module...

Issue #2978498 by Cottser, Kingdutch: Using the module filter on the module list page a module can only be found by system name if the description ends in a dot
parent 982b97a4
No related branches found
No related tags found
26 merge requests!54479.5.x SF update,!5014Issue #3071143: Table Render Array Example Is Incorrect,!4868Issue #1428520: Improve menu parent link selection,!4289Issue #1344552 by marcingy, Niklas Fiekas, Ravi.J, aleevas, Eduardo Morales...,!4114Issue #2707291: Disable body-level scrolling when a dialog is open as a modal,!4100Issue #3249600: Add support for PHP 8.1 Enums as allowed values for list_* data types,!2378Issue #2875033: Optimize joins and table selection in SQL entity query implementation,!2334Issue #3228209: Add hasRole() method to AccountInterface,!2062Issue #3246454: Add weekly granularity to views date sort,!1591Issue #3199697: Add JSON:API Translation experimental module,!1484Exposed filters get values from URL when Ajax is on,!1255Issue #3238922: Refactor (if feasible) uses of the jQuery serialize function to use vanillaJS,!1162Issue #3100350: Unable to save '/' root path alias,!1105Issue #3025039: New non translatable field on translatable content throws error,!1073issue #3191727: Focus states on mobile second level navigation items fixed,!10223132456: Fix issue where views instances are emptied before an ajax request is complete,!925Issue #2339235: Remove taxonomy hard dependency on node module,!877Issue #2708101: Default value for link text is not saved,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links,!844Resolve #3036010 "Updaters",!617Issue #3043725: Provide a Entity Handler for user cancelation,!579Issue #2230909: Simple decimals fail to pass validation,!560Move callback classRemove outside of the loop,!555Issue #3202493,!485Sets the autocomplete attribute for username/password input field on login form.,!30Issue #3182188: Updates composer usage to point at ./vendor/bin/composer
......@@ -44,9 +44,10 @@
'.table-filter-text-source, .module-name, .module-description',
);
let sourcesConcat = '';
// Concatenate the textContent of the elements in the row.
// Concatenate the textContent of the elements in the row, with a
// space in between.
sources.forEach((item) => {
sourcesConcat += item.textContent;
sourcesConcat += ` ${item.textContent}`;
});
const textMatch = sourcesConcat.search(re) !== -1;
$(row).closest('tr').toggle(textMatch);
......
......@@ -68,6 +68,14 @@ public function testModuleFilter() {
$expected_message = '1 module is available in the modified list.';
$assertSession->elementTextContains('css', '#drupal-live-announce', $expected_message);
// Test filtering by a machine name, when the module description doesn't end
// with a period or other separator. This condition is common for test
// modules.
$filter->setValue('comment_base_field_test');
$session->wait(1000, 'jQuery("#module-node:visible").length == 0');
$visible_rows = $this->filterVisibleElements($module_rows);
self::assertEquals(1, count($visible_rows));
// Test Drupal.announce() message when no matches are expected.
$filter->setValue('Pan-Galactic Gargle Blaster');
$session->wait(1000, 'jQuery("#module-node:visible").length == 0');
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment