Skip to content
Snippets Groups Projects
Verified Commit 7527a854 authored by Lee Rowlands's avatar Lee Rowlands
Browse files

Issue #3338973 by Lendude, cbfannin, ericdsd, marc.groth: Deprecated:...

Issue #3338973 by Lendude, cbfannin, ericdsd, marc.groth: Deprecated: preg_split(): Passing null in argument_validator

(cherry picked from commit c4bbc93c)
parent 9331f98b
No related branches found
No related tags found
20 merge requests!11628Update file MediaLibraryWidget.php,!7564Revert "Issue #3364773 by roshnichordiya, Chris Matthews, thakurnishant_06,...,!5752Issue #3275828 by joachim, quietone, bradjones1, Berdir: document the reason...,!5627Issue #3261805: Field not saved when change of 0 on string start,!5427Issue #3338518: send credentials in ajax if configured in CORS settings.,!5395Issue #3387916 by fjgarlin, Spokje: Each GitLab job exposes user email,!5217Issue #3386607 by alexpott: Improve spell checking in commit-code-check.sh,!5064Issue #3379522 by finnsky, Gauravvvv, kostyashupenko, smustgrave, Chi: Revert...,!5040SDC ComponentElement: Transform slots scalar values to #plain_text instead of throwing an exception,!4958Issue #3392147: Whitelist IP for a Ban module.,!4894Issue #3280279: Add API to allow sites to opt in to upload SVG images in CKEditor 5,!4857Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!4856Issue #3336994: StringFormatter always displays links to entity even if the user in context does not have access,!4788Issue #3272985: RSS Feed header reverts to text/html when cached,!4716Issue #3362929: Improve 400 responses for broken/invalid image style routes,!4553Draft: Issue #2980951: Permission to see own unpublished comments in comment thread,!3679Issue #115801: Allow password on registration without disabling e-mail verification,!3106Issue #3017548: "Filtered HTML" text format does not support manual teaser break (<!--break-->),!925Issue #2339235: Remove taxonomy hard dependency on node module,!872Draft: Issue #3221319: Race condition when creating menu links and editing content deletes menu links
......@@ -177,7 +177,7 @@ public function submitOptionsForm(&$form, FormStateInterface $form_state, &$opti
public function validateArgument($argument) {
$entity_type = $this->definition['entity_type'];
if ($this->multipleCapable && $this->options['multiple']) {
if ($this->multipleCapable && $this->options['multiple'] && isset($argument)) {
// At this point only interested in individual IDs no matter what type,
// just splitting by the allowed delimiters.
$ids = array_filter(preg_split('/[,+ ]/', $argument));
......
......@@ -129,6 +129,7 @@ public function testValidateArgumentNoAccess() {
$this->assertFalse($this->argumentValidator->validateArgument(3));
$this->assertFalse($this->argumentValidator->validateArgument(''));
$this->assertFalse($this->argumentValidator->validateArgument(NULL));
$this->assertTrue($this->argumentValidator->validateArgument(1));
$this->assertTrue($this->argumentValidator->validateArgument(2));
......@@ -249,6 +250,8 @@ public function testValidateArgumentMultiple() {
$this->assertFalse($this->argumentValidator->validateArgument('1,2'));
$this->assertFalse($this->argumentValidator->validateArgument('1+2'));
$this->assertFalse($this->argumentValidator->validateArgument(NULL));
$options = [];
$options['access'] = TRUE;
$options['bundles'] = [];
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment