Commit 722d8fba authored by catch's avatar catch
Browse files

Issue #3417362 by kristiaanvandeneynde, smustgrave, quietone: Call... 

Issue #3417362 by kristiaanvandeneynde, smustgrave, quietone: Call refreshVariables() where needed in various tests

(cherry picked from commit 5ce1a1b4)
parent 24c236fd

core/modules/comment/tests/src/Functional/Rest/CommentResourceTestBase.php

+3 −0
Original line number Diff line number Diff line
@@ -359,6 +359,9 @@ public function testPostSkipCommentApproval() { 
    $this->assertResourceResponse(201, FALSE, $response);

    $this->assertFalse($unserialized->isPublished());



    // Make sure the role save below properly invalidates cache tags.

    $this->refreshVariables();



    // Grant anonymous permission to skip comment approval.

    $this->grantPermissionsToTestedRole(['skip comment approval']);

core/modules/media/tests/src/Functional/MediaOverviewPageTest.php

+6 −0
Original line number Diff line number Diff line
@@ -86,6 +86,9 @@ public function testMediaOverviewPage() { 
    ]);

    $media3->save();



    // Make sure the role save below properly invalidates cache tags.

    $this->refreshVariables();



    // Verify the view is now correctly populated. The non-admin user can only

    // view published media.

    $this->grantPermissions($role, [
@@ -138,6 +141,9 @@ public function testMediaOverviewPage() { 
    $assert_session->elementExists('css', 'td.views-field-operations li a:contains("Delete")', $row1);

    $assert_session->linkByHrefExists('/media/' . $media1->id() . '/delete');



    // Make sure the role save below properly invalidates cache tags.

    $this->refreshVariables();



    // Make the user the owner of the unpublished media item and assert the

    // media item is only visible with the 'view own unpublished media'

    // permission.

core/modules/media/tests/src/Functional/Rest/MediaResourceTestBase.php

+3 −0
Original line number Diff line number Diff line
@@ -375,6 +375,9 @@ protected function uploadFile() { 
    static::recursiveKSort($actual);

    $this->assertSame($expected, $actual);



    // Make sure the role save below properly invalidates cache tags.

    $this->refreshVariables();



    // To still run the complete test coverage for POSTing a Media entity, we

    // must revoke the additional permissions that we granted.

    $role = Role::load(static::$auth ? RoleInterface::AUTHENTICATED_ID : RoleInterface::ANONYMOUS_ID);

core/modules/node/tests/src/Functional/Rest/NodeResourceTestBase.php

+3 −0
Original line number Diff line number Diff line
@@ -255,6 +255,9 @@ public function testPatchPath() { 
    $this->assertSame('/llama', $this->entityStorage->loadUnchanged($this->entity->id())->get('path')->alias);

    $this->assertResourceErrorResponse(403, "Access denied on updating field 'path'. " . static::$patchProtectedFieldNames['path'], $response);



    // Make sure the role save below properly invalidates cache tags.

    $this->refreshVariables();



    // Grant permission to create URL aliases.

    $this->grantPermissionsToTestedRole(['create url aliases']);