Verified Commit 6faec7c9 authored by Jess's avatar Jess
Browse files

Issue #3537720 by acbramley, mstrelan: Remove return type from BlockBase::submitConfigurationForm()

parent adce53d0

core/.phpstan-baseline.php

+6 −0
Original line number Diff line number Diff line
@@ -1741,6 +1741,12 @@ 
	'count' => 1,

	'path' => __DIR__ . '/lib/Drupal/Core/Block/BlockBase.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\Core\\\\Block\\\\BlockBase\\:\\:submitConfigurationForm\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

	'count' => 1,

	'path' => __DIR__ . '/lib/Drupal/Core/Block/BlockBase.php',

];

$ignoreErrors[] = [

	'message' => '#^Method Drupal\\\\Core\\\\Block\\\\BlockBase\\:\\:traitBuildConfigurationForm\\(\\) has no return type specified\\.$#',

	'identifier' => 'missingType.return',

core/lib/Drupal/Core/Block/BlockBase.php

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta 
  /**

   * {@inheritdoc}

   */

  public function submitConfigurationForm(array &$form, FormStateInterface $form_state): void {

  public function submitConfigurationForm(array &$form, FormStateInterface $form_state) {

    if (!$form_state->getErrors() && $form_state->getValue('context_mapping')) {

      $this->configuration['context_mapping'] = $form_state->getValue('context_mapping');

    }